Repository navigation
Write _source filtering of bulk update actions as a source filter object - #4208
Merged
Philippus merged 1 commit intoNov 10, 2026
Merged
Conversation
The bulk action line wrote includes and excludes as _source_includes and _source_excludes, which are URL parameters of the update API, so Elasticsearch and OpenSearch rejected the whole bulk request. Write them as a _source object with includes and excludes instead, as the search and multi get builders already do.
EDALJO
marked this pull request as ready for review
November 9, 2026 22:20
Owner
|
thanks, nice catch! |
Contributor
Author
|
Cheers — thanks for the swift merge! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A bulk update with
fetchSource(includes, excludes)fails the whole bulk request withunknown parameter [_source_includes].Design
_sourceobject on the action line:_source_includes/_source_excludesare update API URL parameters, not bulk metadata.FetchSourceContextBuilderFn: search and inner hits already serialize source filtering through it.fetchSource(true)andfetchSource(false)are unchanged: only filtered requests produce different output.Notes for reviewers
series/8.xhas the same builder code: should this be backported there too?