Skip to content

Performance: Fix O(N^2) DB write bottleneck in start_model_runs.R for… #4045

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
anushkagupta200615-jpg wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Performance: Fix O(N^2) DB write bottleneck in start_model_runs.R for… #4045

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 7 additions & 6 deletions base/workflow/R/start_model_runs.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -321,12 +321,7 @@ start_model_runs <- function(settings, write = TRUE, stop.on.error = TRUE) {
}

# Write finish time to database
#TODO this repeats for every run in `jobids` writing every run's time stamp every time. This actually takes quite a long time with a lot of ensembles and should either 1) not be a for loop (no `for(x in run_list)`) or 2) if `is_modellauncher`, be done outside of the jobids for loop after all jobs are finished.
if (is_modellauncher && write) {
for (x in run_list) {
PEcAn.DB::stamp_finished(con = dbcon, run = x)
}
} else {
if (!is_modellauncher) {
if (write) {
PEcAn.DB::stamp_finished(con = dbcon, run = run)
}
Expand All @@ -350,6 +345,12 @@ start_model_runs <- function(settings, write = TRUE, stop.on.error = TRUE) {
} # end loop over runs
} # end while loop checking runs

if (is_modellauncher && write) {
for (x in run_list) {
PEcAn.DB::stamp_finished(con = dbcon, run = x)
}
}

# Copy data back to local
if (!is_local) {
PEcAn.utils::retry.func(
Expand Down