Don't call curl_close on PHP 8.0 or higher, it doesn't do anything an… - #145
Merged
regdos merged 1 commit intoJun 22, 2026
Merged
Conversation
…d got deprecated in PHP 8.5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…d got deprecated in PHP 8.5
See the documentation: https://www.php.net/manual/en/function.curl-close.php
This module declares itself as needing PHP 7.4 or higher. So we can't fully remove this function call, hence it's now wrapped in a check to see which PHP version is running the code to only execute on PHP < 8.0. So we get no deprecated warning when running this code on PHP 8.5 or higher.