feature(minimessage): Add tag resolver type hints - #1444
Open
flennium wants to merge 1 commit into
Open
Conversation
flennium
marked this pull request as ready for review
August 8, 2026 21:36
flennium
force-pushed
the
agent/1424-tag-resolver-type-hints
branch
from
August 10, 2026 21:51
ca8b467 to
2286bd8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1424
Summary
MiniMessage currently resolves ordinary tags during both the preprocessing and normal parsing passes. This adds an additive
TagResolver#tagType(String)hint so resolvers can identify known non-PreProcesstags and avoid the unnecessary preprocessing resolution.Existing resolvers that do not provide the hint retain the previous behavior. Built-in single-tag, mapped, cached, and composed resolvers propagate available type information.
Testing
PreProcesstags still resolve during preprocessing../gradlew :adventure-text-minimessage:check --rerun./gradlew check --rerun