feature(api): Add locale-specific translation unregistering - #1441
Open
ZapolyarnyDev wants to merge 1 commit into
Open
feature(api): Add locale-specific translation unregistering#1441ZapolyarnyDev wants to merge 1 commit into
ZapolyarnyDev wants to merge 1 commit into
Conversation
kashike
reviewed
Aug 20, 2026
|
|
||
| @Override | ||
| public final void unregister(final String key, final Locale locale) { | ||
| this.translations.computeIfPresent(requireNonNull(key, "key"), (ignored, translation) -> { |
Member
There was a problem hiding this comment.
Why computeIfPresent? I don't know why we need to create one if absent when we are unregistering.
Author
There was a problem hiding this comment.
I used computeIfPresent specifically to avoid creating a translation entry when unregistering an unknown key. If the key exists, we remove the locale; if no locales remain, returning null removes the key. Otherwise, it’s a no-op.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
TranslationStore#unregister(String, Locale)to allow unregistering a translation for a specific locale without affecting the other translations for that keyIncludes tests for preserving other locales and removing empty keys
Closes #1361