Repository navigation
fix(probe): stop descendant work after POSIX timeouts - #751
Open
rudycelekli wants to merge 1 commit into
Open
rudycelekli wants to merge 1 commit into
rudycelekli wants to merge 1 commit into
Conversation
Signed-off-by: Rudy Celekli <47457359+rudycelekli@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
A timed-out POSIX health probe kills its immediate command but leaves children of CLI wrappers running. Repeated doctor calls or retries can therefore accumulate work after the caller has received a timeout.
The native regression launches a wrapper that starts a child; the child writes a marker after the one-second probe deadline. On unchanged main the marker appears, both when the wrapper is still running and when it has already exited while the child holds its output pipes.
Change
Give each POSIX health probe its own process session. On timeout or interruption, terminate that owned process group before the normal subprocess cleanup. Preserve status/output classification, environment isolation, retries, and the existing non-POSIX
subprocess.runpath. Existing channel unit tests now stub the POSIX execution boundary as well as the non-POSIX boundary; native probe tests still execute real processes.This addresses orphaned probe work, not an overall doctor deadline or parallel channel collection. It does not claim to resolve the entire hang report in #732. The separate inherited-pipe hang hypothesis was tested and did not reproduce on this POSIX Python runtime.
Validation
AI assistance: prepared with Codex and independently reviewed before submission.