Repository navigation
fix(mcp): constrain installs to the supported SDK API - #749
Open
rudycelekli wants to merge 1 commit into
Open
rudycelekli wants to merge 1 commit into
rudycelekli wants to merge 1 commit into
Conversation
Signed-off-by: Rudy Celekli <47457359+rudycelekli@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The
allextra permits MCP SDK 2.x, but this server uses the SDK 1.x low-level decorator API. A fresh install resolving MCP 2.2.0 fails increate_server()withAttributeError: 'Server' object has no attribute 'list_tools'before it can serve any tools. Existing fake-Server tests do not detect this dependency incompatibility.Change
Constrain the existing MCP dependency to
>=1.0,<2until the integration is migrated to the new API. Add an optional real-SDK smoke test that initializes a client session, listsget_status, and calls it. Only the synchronous doctor response is stubbed; tool registration and the MCP exchange use the actual SDK.This is distinct from #624's missing
mcpextra and #697's event-loop fix: it changes the supported dependency range, not the advertised extras or handler concurrency.Validation
.[all,dev]against repository constraints selects MCP 1.30.0; native SDK smoke and existing MCP tests pass (3 tests), and the full suite passes (608 tests).SDK v2's documented low-level API uses constructor callbacks rather than these decorators.
AI assistance: prepared with Codex, independently reviewed, and verified using the native SDK before submission.