Repository navigation
fix: restore subpath resolution for barrel directories - #22
Merged
Merged
Conversation
#20 replaced the `"./*"` fallback array with a single `"./src/lib/*"`. That was right to do — publint flags fallback arrays, and Node only ever resolves the first entry, so the other two only worked because bundlers implement them — but it also removed the `index.ts` resolution that every directory subpath depended on. `@openshock/svelte-core/utils` names a directory, so it stopped resolving entirely; the cloud frontend goes from clean to 510 errors across 163 files on this package alone. Enumerates the 53 barrel directories explicitly instead. `"./*"` stays for direct file imports. Explicit subpaths beat patterns in Node's resolution and each one names a real file, so `publint --strict` is clean and the public surface is now deliberate rather than a side effect of globbing. Generated from the barrels rather than hand-written, so it can be regenerated the same way when components are added.
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
hhvrc
added a commit
that referenced
this pull request
Aug 20, 2026
Brings #20, #21 and #22 onto the migration branch. package.json keeps this branch's `next` pins for `@sveltejs/kit` and `@sveltejs/adapter-auto` while taking master's removal of `@sveltejs/package`, which #20 dropped and nothing here uses. pnpm-lock.yaml is regenerated from this branch's copy rather than master's, so the SvelteKit 3 prereleases stay pinned and master's dependency changes resolve on top. eslint.config.js needed a fix git could not see: it imported `./svelte.config.js` for the parser's `svelteConfig` option, and the migration deleted that file in favour of vite.config.ts. The option is an optimisation rather than a requirement, so it is dropped here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.