Cache liberty-plugin-config.xml and server properties - #403
Merged
Merged
Conversation
Reduces the number of walks down to 2 when auto-completing a feature.
venmanyarun
requested changes
Aug 24, 2026
Member
There was a problem hiding this comment.
Make sure to run ./mvnw clean install in both liberty-ls and lemminx-liberty , so that all tests including IT are verified
testGetFeatures() in lemminx-liberty/src/it/schema-gen-wlp-it will be failing.. you need to provide the latest version of liberty(26.0.0.8) in the last line instead of 26.0.0.2
org.junit.jupiter.api.Assertions.assertEquals(SettingsService.getInstance().getLatestRuntimeVersion(), "26.0.0.2");
Also, can you add screen recordings from windows fyre VM before and after the changes?
venmanyarun
reviewed
Aug 24, 2026
Contributor
Author
|
Added Windows Fyre VM recordings of features auto-completion before and after this PR. |
venmanyarun
approved these changes
Aug 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Should fix OpenLiberty/liberty-tools-vscode#329 by reducing the number of walks from 14 down to 2 when auto-completing a feature in server.xml
Not sure how we could test this, but the logic should work assuming the file watching works.
Side note: the performance issue was introduced in GH-207 since the getLibertyPropertiesFile method does 3 walks and the method it's in (getLibertyRuntimeInfo) is called 4 times, hence adding 12 walks to each LSP request. On a Windows Fyre VM, it increases the delay between pressing Ctrl+Space and seeing the features from around 2 seconds to 6.
Current (click to expand):
old.mp4
This PR (click to expand):
new.mp4