Repository navigation
Keep the flight's source recordings in the S3 backup, with the recipe - #403
Merged
Merged
Conversation
Both originals of the mabur-2026-10 flight are now in the backup bucket, once, at boards/flights/mabur-2026-10/ with a SHA256SUMS -- uploaded from the host's verified copy and checked by downloading them back. boards/ because it is the prefix the backup's IAM user may write and it is outside the expiring rotation; media-sources/ is refused. tools/flight-ab/README.md now carries the whole recipe from those objects to what /low-latency streams: fetch and verify, run.sh with the poster moment, publish into v2, and the offset, window and stats a correct run reproduces. RESTORE.md points there instead of saying the sources are only on the host.
Code Review by Qodo🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0)
Great, no issues found!Qodo reviewed your code and found no material issues that require reviewTip of the day💡 Did you know, you can route each severity your way: inline, summary, both, or drop |
PR Summary by QodoDocument S3-backed flight sources and the stream rebuild recipe
AI Description
Diagram
High-Level Assessment
Files changed (2)
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The two original recordings behind /low-latency's flight comparison (#401) are now backed up once in S3 at
boards/flights/mabur-2026-10/with aSHA256SUMS. I uploaded them from the host's verified copy and downloaded them back to check them; both match.They go under
boards/because that is the prefix the backup's IAM user may write, and it sits outside the expiring daily/weekly/monthly rotation.media-sources/is refused. The user cannot delete objects, so a 6-byte write probe stays atboards/flights/probe; it is documented.tools/flight-ab/README.mdnow has the full recipe from those objects to what the page streams:SHA256SUMS.run.shwith the poster moment.v2.It also lists the offset, window and stats a correct run reproduces.
deploy/RESTORE.mdpoints there.Docs only; nothing deploys.