Streaming decoder support2 - #3551
Open
trumpetinc wants to merge 2 commits into
Open
Conversation
Collaborator
Author
|
Fixing problems with initial git branch ( #3494 ) |
Collaborator
Author
|
@velo let's try this - I have no idea what I messed up with the git branching on the earlier PR. This PR is as clean as I can make it. I branched from the latest 14.x and made the required changes. CircleCI is already complaining about build problems (certainly nothing to do with this PR itself??): But at least security snyk checked out this time. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds support for streaming decode for Feign RequestLine methods that return InputStream or Reader.
To use:
Changes
InvocationContextnow leaves the response stream open if the return type from the decoder implementsCloseableInputStreamAndReaderDecoderclass that can be registered with the Feignbuilder.decoder()method. Supports passing the decode request to a delegate if the method return type is notInputStreamorReader. If the return type isReader, the charset of the response Content-Type header is used. If no charset is specified in the header, UTF-8 is assumed.ContentTypeParserutility method for obtaining information from the Content-Type header