Allow retryable exceptions without a request - #3548
Open
taljeon wants to merge 1 commit into
Open
Conversation
Add no-request overloads for both cause and no-cause paths using the current millisecond retry-after type. OpenAI Codex assisted with implementation and validation; the final changes were reviewed and verified. Fixes OpenFeign#1296
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
RetryableExceptionoverloads that do not require or retain aRequestLong retryAftervalueTesting
mvn -pl core -Pdev -Dtoolchain.skip=true -Dtest=RetryableExceptionTest test(5 passed)mvn -pl core -Pdev -Dtoolchain.skip=true verify(731 passed, 4 skipped)mvn clean install -pl core -Pdev -Dtoolchain.skip=true(731 passed, 4 skipped)git diff --checkAI assistance
OpenAI Codex assisted with code navigation, implementation, and validation. I reviewed and verified the final changes.
Fixes #1296