Add opt-in target host and port observation tags - #3546
Open
henriquejsza wants to merge 1 commit into
Open
Conversation
* Add a convention that emits the configured target host and explicit port. * Keep the default low-cardinality key set unchanged. * Cover explicit, omitted, and URL-less targets and document opt-in usage. Fixes OpenFeign#2630
henriquejsza
force-pushed
the
fix/micrometer-target-host-port
branch
from
August 28, 2026 20:11
f2be94e to
6e282cf
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TargetHostAndPortFeignObservationConventionnet.peer.hostand an explicitly configurednet.peer.portsupportsContextis declared explicitly with the existing semantics so JApiCmp can validate the new public convention.Testing
./mvnw -Pdev -Dtoolchain.skip=true -pl micrometer -am verifyFixes #2630