Skip to content

Document that Logger reflects Feign's Request, not the wire request #3544

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ChrisJr404 wants to merge 1 commit into
base: master
Choose a base branch
from
+12 −1
Open

Document that Logger reflects Feign's Request, not the wire request #3544

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion core/src/main/java/feign/Logger.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,18 @@
import java.util.logging.LogRecord;
import java.util.logging.SimpleFormatter;

/** Simple logging abstraction for debug messages. Adapted from {@code retrofit.RestAdapter.Log}. */
/**
* Simple logging abstraction for debug messages. Adapted from {@code retrofit.RestAdapter.Log}.
*
* <p>Request logging reflects the {@link Request} that Feign builds from the method invocation,
* captured before it is handed to the {@link Client}. Depending on the {@link Client}
* implementation, the bytes actually sent over the wire may differ from what is logged here. In
* particular the default {@link Client.Default} is backed by {@link java.net.HttpURLConnection},
* which silently drops headers the JDK treats as restricted (for example {@code Host}, {@code
* Connection} and {@code Content-Length}) unless the {@code sun.net.http.allowRestrictedHeaders}
* system property is set, so such a header can appear in the log without being present in the
* outgoing request.
*/
public abstract class Logger {

protected static String methodTag(String configKey) {
Expand Down