Skip to content

Getting the sha via the Heroku API will fail after 200 commits #8

Description

@pezholio

At the moment, we get the commit sha for the provenance using the Heroku API, which is a bit messy, but due to the lack of a filesystem, we can't use Git to get the current SHA:

https://github.com/OpenAddressesUK/distiller/blob/master/lib/helpers.rb#L12

Also, this will break eventually as the Heroku API gem only returns the first 200 commits. We probably need to fix this before we hit 200 commits.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions