chore(deps): declare httpclient5 and commons-io where they are actually used - #7661
Merged
Romuald Lemesle (RomuDeuxfois) merged 1 commit intoAug 28, 2026
Merged
Conversation
…ly used openaev-framework declared both and imports neither. openaev-model imports HttpClient 5 in OpenSearchDriver and declares nothing, so it only compiles because the OpenSearch client happens to drag the library along. Since framework depends on model and not the reverse, the framework declaration was never what put the library on model's classpath: it was dead either way. Resolution is unchanged, httpclient5 5.6.4 and commons-io 2.22.0.
Contributor
|
📖 Documentation check — ✅ Passed No functional source changes detected. |
Copilot started reviewing on behalf of
Romuald Lemesle (RomuDeuxfois)
August 28, 2026 10:21
View session
Contributor
There was a problem hiding this comment.
Pull request overview
This PR aims to align Maven dependency declarations with actual module usage by removing unused declarations from openaev-framework and explicitly declaring httpclient5 in openaev-model (where OpenSearchDriver imports Apache HttpClient 5 APIs).
Changes:
- Remove
httpclient5andcommons-iodependencies fromopenaev-framework(no usage there). - Add
httpclient5toopenaev-model(intended to avoid relying on transitive pulls from the OpenSearch client).
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| openaev-model/pom.xml | Adds httpclient5 declaration (currently added under dependencyManagement). |
| openaev-framework/pom.xml | Removes unused httpclient5 and commons-io dependencies. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+24
to
+28
| <!-- Used directly by OpenSearchDriver; only reached us through the OpenSearch client. --> | ||
| <dependency> | ||
| <groupId>org.apache.httpcomponents.client5</groupId> | ||
| <artifactId>httpclient5</artifactId> | ||
| <version>${httpclient5.version}</version> |
Romuald Lemesle (RomuDeuxfois)
deleted the
chore/declare-deps-where-used
branch
August 28, 2026 12:21
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
openaev-frameworkdeclares both libraries and imports neither — 0 occurrences, imports and qualified names, main and test.openaev-modelimports HttpClient 5 inOpenSearchDriverand declares nothing, so it only compiles because the OpenSearch client happens to drag the library along.