Skip to content

feat(marking): task.1 - Create & Manage marking (#7511) - #7651

Draft
damgouj (damgouj) wants to merge 6 commits into
mainfrom
issue/7511
Draft

feat(marking): task.1 - Create & Manage marking (#7511)#7651
damgouj (damgouj) wants to merge 6 commits into
mainfrom
issue/7511

Conversation

@damgouj

Copy link
Copy Markdown
Member

Proposed changes

  • Implement markings capabilities
  • Implement CRUD markings Front and Back
  • Init default TLP markings

Testing Instructions

  1. Check the issue and the 6 US in Github and Notion
  2. Test markings capa
  3. Test the new markings screen with the CRUD
  4. Check that the migration is OK for fresh/migrate database and new tenants

Related issues

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality
  • I wrote test cases for the relevant uses case
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality
  • For bug fix -> I implemented a test that covers the bug

# Conflicts:
#	openaev-front/src/admin/components/nav/config/settings.config.tsx
#	openaev-front/src/admin/components/settings/Index.tsx
#	openaev-front/src/admin/components/settings/SecurityMenu.tsx
@damgouj damgouj (damgouj) self-assigned this Aug 28, 2026
@damgouj damgouj (damgouj) added the filigran team Item from the Filigran team. label Aug 28, 2026
@github-actions

Copy link
Copy Markdown
Contributor

📖 Documentation check — ❌ Failed

36 functional file(s) changed, 0 documentation file(s) changed.

Blocking gaps

Update the docs or add the No need documentation label to bypass.

🔴 New REST API controller

  • File: openaev-api/src/main/java/io/openaev/api/marking_definition/MarkingDefinitionApi.java
  • Expected doc update: docs/docs/usage/rest-api.md, docs/docs/development/api-usage.md
  • Reason: New API endpoints must be documented.

Suggestions (non-blocking)

  • 🟡 New preview feature flagopenaev-api/src/main/java/io/openaev/rest/settings/PreviewFeature.javadocs/docs/deployment/configuration.md

Add the No need documentation label to bypass this check when no documentation update is needed.

@damgouj damgouj (damgouj) left a comment

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO:

  • Telemetry
  • Front design:
    • marking menu and list item icon,
    • warning dialog to create?
    • edit marking_type, component to select existing type or write new type?
    • danger zone,
    • disabled instead of hidden,
    • CSS form to check
  • Filter have some bugs
  • Marking capa in Security
  • Fix tests
  • Review Back and especially Front code
  • Doc?
  • Are 3 md files in the right folder?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

filigran team Item from the Filigran team.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat(marking): Task.1 - Create & Manage marking

1 participant