fix(rabbitmq): bound a publish so it cannot hold a transaction open (#7630)

[Romuald Lemesle (RomuDeuxfois)]

Proposed changes

Sending an inject to RabbitMQ happens inside its database transaction, and nothing made that send give up. Java has no socket write timeout, so a broker that stops reading parks the thread forever, holding a connection until the pool is empty and the platform stops answering.

• publish() runs on a separate thread and gives up after openaev.rabbitmq.publish-timeout-ms, 30 s. Only the inject fails.
• Connection timeout 60 s → 10 s.

Contains the damage, does not remove the cause (#7630).

Checks done

ExecutorTest, HealthCheckServiceTest and SimulationInjectApiTest pass. Nothing tests the timeout itself.

[github-actions]

📖 Documentation check — ⚠️ Passed with warnings

3 functional file(s) changed, 0 documentation file(s) changed.

Suggestions (non-blocking)

• 🟡 New configuration property — openaev-model/src/main/java/io/openaev/service/RabbitmqService.java → docs/docs/deployment/configuration.md

---

Add the No need documentation label to bypass this check when no documentation update is needed.

[Copilot]

Pull request overview

This PR adds containment mechanisms around RabbitMQ publishing so that a stalled broker can’t indefinitely block basicPublish and keep database transactions (and therefore row locks / the Hikari pool) held open, preventing platform-wide outages during broker disk/memory alarm conditions.

Changes:

• Add connection-level timeouts/heartbeat on the shared RabbitMQ ConnectionFactory.
• Run RabbitmqService.publish() on a separate executor and enforce a publish timeout (configurable via openaev.rabbitmq.publish-timeout-ms).
• Add a focused test suite for publish timeout vs healthy/error broker behaviors.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

File	Description
openaev-model/src/main/java/io/openaev/service/RabbitmqService.java	Adds bounded-time publish via an executor + timeout and shuts the executor down on bean destroy.
openaev-model/src/main/java/io/openaev/driver/RabbitmqDriver.java	Adds connection timeout / handshake timeout / heartbeat to fail fast on unresponsive brokers.
openaev-api/src/test/java/io/openaev/service/RabbitmqServicePublishTest.java	New unit tests validating timeout behavior, success path, and surfacing broker IO errors.
openaev-api/src/main/resources/application.properties	Introduces openaev.rabbitmq.publish-timeout-ms with documentation.

Suppressed comments (2)

openaev-model/src/main/java/io/openaev/service/RabbitmqService.java:85

• issue (blocking): newFixedThreadPool doesn't actually cap the number of pending publishes (only the number of active threads). Use a ThreadPoolExecutor with a bounded queue (or a SynchronousQueue) so publish requests fail fast once the pool is saturated, keeping memory and downstream load bounded during a broker stall.

  private final ExecutorService publishExecutor =
      Executors.newFixedThreadPool(
          PUBLISH_THREADS,
          runnable -> {
            Thread thread = new Thread(runnable, "rabbitmq-publish");

openaev-model/src/main/java/io/openaev/service/RabbitmqService.java:147

• issue (blocking): once the publish executor is saturated (all threads stuck + queue full), submit(...) will throw RejectedExecutionException. Today that would bubble as an unchecked exception; it’s better to convert this into a controlled failure (e.g., TimeoutException) so callers consistently roll back the inject instead of failing with an unexpected runtime error.

    Future<Void> pending =
        publishExecutor.submit(
            () -> {
              doPublish(injectType, publishedJson);
              return null;

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

[github-actions]

✅ Container vulnerability scan — Passed

Previously reported findings are no longer present.

Image	Critical	High	Total	Status
Standard	0	0	0	✅ Clear
UBI9	0	0	0	✅ Clear

View workflow run · Standard JSON report · UBI9 JSON report

_{Updated from CI run attempt 1.}