fix(teams): trim team names on xls import and allow deleting teams linked to injects (#7558) by johanah29 · Pull Request #7609 · OpenAEV-Platform/openaev

Johanah LEKEU (johanah29) · 2026-08-26T09:33:05Z

Proposed changes

*Add a trim for the creation of teams from xls files
*Allow hte deletion of teams linked to injects

Testing Instructions

Import injects from an xls file. Make sure to have several teams names separated by a comma in the teams cell
The teams must be created and attached to their corresponding injects, no duplicate
Try deleting a team when it is still linked to injects, deletion should succeed without any error

github-actions · 2026-08-26T09:33:16Z

📖 Documentation check — ✅ Passed

2 functional file(s), 0 doc file(s) changed.

No documentation gaps detected.

Copilot

Pull request overview

This PR targets team handling consistency by (1) normalizing team names during XLS inject import and (2) allowing teams to be deleted even when they are linked to injects.

Changes:

Trim imported team name tokens when parsing comma-separated teams during XLS inject import.
Update DELETE /teams/{teamId} to load the tenant-scoped team, detach it from linked injects, and then delete it.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.

File	Description
openaev-api/src/main/java/io/openaev/service/InjectImportService.java	Trims parsed team-name tokens from XLS import before resolving/creating teams.
openaev-api/src/main/java/io/openaev/rest/team/TeamApi.java	Changes delete behavior to fetch the team in-tenant and detach from injects prior to deletion.

Suppressed comments (1)

openaev-api/src/main/java/io/openaev/rest/team/TeamApi.java:253

issue (blocking): Removing the team from inject.getTeams() mutates the join table but does not update inject_updated_at. Inject indexing uses inject_updated_at as part of its cursor/sort key, so team membership changes may not be propagated to Elasticsearch (stale inject_teams until the inject is otherwise updated/reindexed).

      team.getInjects().forEach(inject -> inject.getTeams().remove(team));
      teamRepository.delete(team);

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

+                  .map(String::trim)
                  .toList();


+                  .map(String::trim)
                  .toList();


+    Team team =
+        teamRepository
+            .findByIdAndTenantId(teamId, TenantContext.getCurrentTenant())
+            .orElseThrow(ElementNotFoundException::new);
    try {
-      teamRepository.deleteById(teamId);
+      team.getInjects().forEach(inject -> inject.getTeams().remove(team));
+      teamRepository.delete(team);


…nd restrictions (#7199) Signed-off-by: johanah29 <johanah.lekeu@filigran.io>

…contextual team delete fails with HTTP Signed-off-by: johanah29 <johanah.lekeu@filigran.io>

Signed-off-by: johanah29 <johanah.lekeu@filigran.io>

github-actions · 2026-08-27T13:30:30Z

❔ Container vulnerability scan — Report incomplete

The latest run did not produce both readable reports. Check the workflow run for details.

Image	Critical	High	Total	Status
Standard	—	—	—	❔ Unavailable
UBI9	—	—	—	❔ Unavailable

View workflow run

_{Updated from CI run attempt 1.}

Romuald Lemesle (RomuDeuxfois) · 2026-08-28T06:17:29Z

+                    .split(","))
+            .map(String::trim)
+            .filter(value -> !value.isBlank())
+            .distinct()


todo: that's a huge issue. Having a disctinct here instead of having it on the prod code. Please put the distinct method in openaev-api/src/main/java/io/openaev/service/InjectImportService.java

Romuald Lemesle (RomuDeuxfois) · 2026-08-28T06:18:41Z


+  @DisplayName("Test parse teams cell with spaces and trailing comma")
+  @Test
+  void testParseTeamsCellWithSpacesAndTrailingComma() {


TODO: this test don't test your changes. Please do a real import.

Romuald Lemesle (RomuDeuxfois) · 2026-08-28T06:19:50Z

-    if (!teamRepository.existsByIdAndTenantId(teamId, TenantContext.getCurrentTenant())) {
-      throw new ElementNotFoundException();
-    }
+    Team team =


Todo: you should add a test for this case.

Romuald Lemesle (RomuDeuxfois) · 2026-08-28T06:20:43Z

-    if (!teamRepository.existsByIdAndTenantId(teamId, TenantContext.getCurrentTenant())) {
-      throw new ElementNotFoundException();
-    }
+    Team team =


TODO: can you test on bulk delete team if we have the issue?

Johanah LEKEU (johanah29) changed the title ~~Issue/7558~~ fix(teams): XLS inject import creates duplicate contextual teams and contextual team delete fails with HTTP Aug 26, 2026

github-actions Bot added the filigran team Item from the Filigran team. label Aug 26, 2026

Filigran Automation (Filigran-Automation) changed the title ~~fix(teams): XLS inject import creates duplicate contextual teams and contextual team delete fails with HTTP~~ fix(teams): trim team names on xls import and allow deleting teams linked to injects (#7558) Aug 26, 2026

Johanah LEKEU (johanah29) linked an issue Aug 26, 2026 that may be closed by this pull request

fix(teams): XLS inject import creates duplicate contextual teams (no trimming), and contextual team delete fails with HTTP 500 #7558

Open

Johanah LEKEU (johanah29) marked this pull request as ready for review August 26, 2026 09:49

Copilot AI lite review requested due to automatic review settings August 26, 2026 09:49

Copilot started reviewing on behalf of Johanah LEKEU (johanah29) August 26, 2026 09:50 View session

Copilot AI reviewed Aug 26, 2026

View reviewed changes

Romuald Lemesle (RomuDeuxfois) reviewed Aug 26, 2026

View reviewed changes

Comment thread openaev-api/src/test/java/io/openaev/service/InjectImportServiceTest.java Outdated

Comment thread openaev-api/src/test/java/io/openaev/service/InjectImportServiceTest.java Outdated

Comment thread openaev-api/src/main/java/io/openaev/service/InjectImportService.java

Johanah LEKEU (johanah29) requested a review from Romuald Lemesle (RomuDeuxfois) August 27, 2026 09:40

Johanah LEKEU (johanah29) added 5 commits August 27, 2026 15:03

feat(audit-logging): UI improvement for capability triad visibility a…

6addb54

…nd restrictions (#7199) Signed-off-by: johanah29 <johanah.lekeu@filigran.io>

fix(teams): XLS inject import creates duplicate contextual teams and …

9ae22c5

…contextual team delete fails with HTTP Signed-off-by: johanah29 <johanah.lekeu@filigran.io>

rollback on capabilitiesTab

7dff1ba

Signed-off-by: johanah29 <johanah.lekeu@filigran.io>

test case on trim

eed0056

Signed-off-by: johanah29 <johanah.lekeu@filigran.io>

resolve comments

452882f

Signed-off-by: johanah29 <johanah.lekeu@filigran.io>

Johanah LEKEU (johanah29) force-pushed the issue/7558 branch from 03a4fc1 to 452882f Compare August 27, 2026 13:09

Romuald Lemesle (RomuDeuxfois) reviewed Aug 28, 2026

View reviewed changes

Navigation Menu

Uh oh!

fix(teams): trim team names on xls import and allow deleting teams linked to injects (#7558) - #7609

fix(teams): trim team names on xls import and allow deleting teams linked to injects (#7558)#7609
Johanah LEKEU (johanah29) wants to merge 5 commits into
mainfrom
issue/7558

Johanah LEKEU (johanah29) commented Aug 26, 2026

Uh oh!

github-actions Bot commented Aug 26, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions Bot commented Aug 27, 2026

Uh oh!

Romuald Lemesle (RomuDeuxfois) Aug 28, 2026

Uh oh!

Romuald Lemesle (RomuDeuxfois) Aug 28, 2026

Uh oh!

Romuald Lemesle (RomuDeuxfois) Aug 28, 2026

Uh oh!

Romuald Lemesle (RomuDeuxfois) Aug 28, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

Johanah LEKEU (johanah29) commented Aug 26, 2026

Proposed changes

Testing Instructions

Uh oh!

github-actions Bot commented Aug 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions Bot commented Aug 27, 2026

Uh oh!

Romuald Lemesle (RomuDeuxfois) Aug 28, 2026

Choose a reason for hiding this comment

Uh oh!

Romuald Lemesle (RomuDeuxfois) Aug 28, 2026

Choose a reason for hiding this comment

Uh oh!

Romuald Lemesle (RomuDeuxfois) Aug 28, 2026

Choose a reason for hiding this comment

Uh oh!

Romuald Lemesle (RomuDeuxfois) Aug 28, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

github-actions Bot commented Aug 26, 2026 •

edited

Loading