feat(audit-logging): phase 2 - US.2 - System & Integration Activity Logging (#6383) - #7537
feat(audit-logging): phase 2 - US.2 - System & Integration Activity Logging (#6383)#7537damgouj (damgouj) wants to merge 2 commits into
Conversation
|
📖 Documentation check — ✅ Passed 8 functional file(s), 0 doc file(s) changed. No documentation gaps detected. |
1 similar comment
|
📖 Documentation check — ✅ Passed 8 functional file(s), 0 doc file(s) changed. No documentation gaps detected. |
There was a problem hiding this comment.
Pull request overview
This PR continues the audit-logging rollout (issue #6383) by reducing audit noise from integration “heartbeat” traffic (XTM Composer callbacks, connector health checks, and repeated registration pings) while keeping meaningful integration lifecycle changes auditable.
Changes:
- Introduces “significant state” capture on several connector-related entities to decide when audit logging should be suppressed for non-meaningful updates.
- Adds audit suppression logic in connector registration/healthcheck code paths to avoid repeated/duplicated audit events.
- Explicitly disables audit logging for selected XTM Composer endpoints that are deemed too noisy (connectivity refresh, connector log ingestion).
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| openaev-model/src/main/java/io/openaev/database/model/Injector.java | Marks injector as audit-state capturable; ignores timestamp/securityPlatform fields for significance checks. |
| openaev-model/src/main/java/io/openaev/database/model/Executor.java | Marks executor as audit-state capturable; ignores timestamps for significance checks. |
| openaev-model/src/main/java/io/openaev/database/model/ConnectorInstancePersisted.java | Marks connector instance as audit-state capturable; ignores startedAt and logs for significance checks. |
| openaev-model/src/main/java/io/openaev/database/model/Collector.java | Marks collector as audit-state capturable; ignores timestamps/securityPlatform for significance checks. |
| openaev-api/src/main/java/io/openaev/service/InjectorService.java | Captures before/after significant state on external injector upsert; suppresses audit when unchanged. |
| openaev-api/src/main/java/io/openaev/service/connector_instances/ConnectorInstanceService.java | Captures before/after state on healthcheck patch; suppresses audit when unchanged. |
| openaev-api/src/main/java/io/openaev/rest/collector/service/CollectorService.java | Captures before/after significant state on collector upsert; suppresses audit when unchanged. |
| openaev-api/src/main/java/io/openaev/api/xtm_composer/XtmComposerApi.java | Disables audit logging for noisy XTM Composer endpoints. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
|
Core CI reports these findings in advisory mode. Review the JSON reports before merging.
View workflow run · Standard JSON report · UBI9 JSON report Updated from CI run attempt 1. |
|
Silence, at last ;) |
Proposed changes
Testing Instructions
Related issues
Checklist