feat(prowler): chunk14 add the CIS benchmark contract (#422) - #444
Draft
Christophe Melchior (Kakudou) wants to merge 5 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #422.
Chunk 14 of the Prowler injector stack: add the CIS benchmark contract — the CHK.014 CIS benchmark assessment: the BDD suite (behaviour, OCSF status / lifecycle logs / verbose diagnostics / OCSF capture fixtures), the new
contracts/cis.pydefining the four canonical routescis/aws,cis/azure,cis/gcp,cis/kubernetesagainst the Prowler 5.36 CIS benchmarks (cis_3.0_aws,cis_3.0_azure,cis_3.0_gcp,cis_1.12_kubernetes), the compliance-validation isolation in_core/prowler_client/client.py(compliance selectors that target another provider's benchmark are rejected before credential materialization), their registration in the registry /__init__, and the cross-chunk registry-alignment BDD updates (chk001, chk007, chk008, chk009, chk010, chk011, chk012, chk013) plus the chk006 unit registry expectations. Existing check and service selection channels are untouched.Re-landed from
feat/422-prowler-chk014-compliance-cis-benchmark(888d5a3..c75f7a9): 12 source commits folded into 5 (O1:b0c2668; O2:6af19d4+4c7f295+12b3714+063e5fd; O3:a3591b1+80d8baa+c75f7a9; O4:f2a869f; O5:0d491c3). O2 landed at the source-final post-image of the CHK.014 BDD suite, so the three later alignment commits folded in as content with zero conflicts, and the later layers' BDD/client.pypost-images were no-ops wherever already carried. The planned sixth layer (style:8a4bf8a+719efb4, a re-titled formatting/lint pass overclient.pyand the BDD) was empty under the final-postimage rule — its format and lint content is already fully contained in O2's final BDD and O3's finalclient.py— and was dropped by call, so the fold lands as 12 → 5. Gate V (whole-branch tree vs source tipc75f7a9): byte-identical except (a) the 14pyproject.tomlversion differences of the other injectors (source base3.260805.0vs re-land base3.260821.0;prowler/subtree untouched), (b) the 11trap-analysis.mdfiles (chk004–chk014) excluded by standing call, and (c) one approved deviation — the pinnedpyoaevversion assert removed fromprowler/tests/unit/chk006_executable_base/test_outputs_registry_runtime.py.