Skip to content

Fix Windows playback reveal issue - #927

Draft
OliverZhaohaibin wants to merge 4 commits into
edit-basefrom
codex/windows-playback-first-open-fix
Draft

Fix Windows playback reveal issue#927
OliverZhaohaibin wants to merge 4 commits into
edit-basefrom
codex/windows-playback-first-open-fix

Conversation

@OliverZhaohaibin

Copy link
Copy Markdown
Owner

This pull request implements a demand-driven warm-up mechanism for the Windows OpenGL Python runtime, improving startup performance and reliability by deferring heavy imports until after user interaction. It also enhances the detail surface reveal logic with a bounded wait and explicit event tracking for composition and deadline-based reveals, ensuring robust handling of stale or missing transitions. The most important changes are grouped below.

Windows OpenGL Python Runtime Warm-up Improvements:

  • Added a demand-driven warm-up for the Windows OpenGL Python runtime, triggered only after startup is complete and upon user interaction (hover/click), never during startup. This is coordinated through new methods in PlayerViewController and desktop_coordinator_runtime.py, and is enabled in main.py after startup. [1] [2] [3] [4]
  • The warm-up is scheduled during detail image display and prefetch operations, and only for the OpenGL backend on Windows. [1] [2] [3]

Detail Surface Reveal and Deadline Handling:

  • Introduced a bounded reveal wait (with a 250ms deadline) for detail surfaces after content submission, with explicit event emission for post_submit_scheduled, post_submit_armed, post_submit_deadline, surface_revealed, and post_submit_discarded. This ensures that missing or stale transitions are handled gracefully and do not reveal outdated content. [1] [2] [3] [4] [5] [6] [7] [8]

Documentation Updates:

  • Updated architecture and benchmark runbook documentation to clarify that Windows OpenGL warm-up is demand-driven and not a startup prerequisite, and to document the new event sequence for reveal deadlines and discards. [1] [2] [3]

These changes improve startup responsiveness, ensure correct event tracking for detail surface transitions, and make the OpenGL runtime initialization more robust and user-driven.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant