Fix Windows playback reveal issue - #927
Draft
OliverZhaohaibin wants to merge 4 commits into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request implements a demand-driven warm-up mechanism for the Windows OpenGL Python runtime, improving startup performance and reliability by deferring heavy imports until after user interaction. It also enhances the detail surface reveal logic with a bounded wait and explicit event tracking for composition and deadline-based reveals, ensuring robust handling of stale or missing transitions. The most important changes are grouped below.
Windows OpenGL Python Runtime Warm-up Improvements:
PlayerViewControlleranddesktop_coordinator_runtime.py, and is enabled inmain.pyafter startup. [1] [2] [3] [4]Detail Surface Reveal and Deadline Handling:
post_submit_scheduled,post_submit_armed,post_submit_deadline,surface_revealed, andpost_submit_discarded. This ensures that missing or stale transitions are handled gracefully and do not reveal outdated content. [1] [2] [3] [4] [5] [6] [7] [8]Documentation Updates:
These changes improve startup responsiveness, ensure correct event tracking for detail surface transitions, and make the OpenGL runtime initialization more robust and user-driven.