i.eb.hsebal95: fix iteration loop - #1777
Open
YannChemin wants to merge 6 commits into
Open
Conversation
The iteration loop for (ic = 1; ic < iteration + 1; ic++) runs ic up to iteration inclusive, and iteration is capped at ITER_MAX (10, the default) just above the loop — so with default settings every one of these stack arrays gets written at index 10, one past its declared size of 10 (valid indices 0-9). Classic off-by-one stack buffer overflow.
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The iteration loop for (ic = 1; ic < iteration + 1; ic++) runs ic up to iteration inclusive, and iteration is capped at ITER_MAX (10, the default) just above the loop — so with default settings every one of these stack arrays gets written at index 10, one past its declared size of 10 (valid indices 0-9). Classic off-by-one stack buffer overflow.