Skip to content

Restore cwd reliably in build-xml module scanning #1647

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ashishkrshaw wants to merge 1 commit into
base: grass8
Choose a base branch
from
Open

Restore cwd reliably in build-xml module scanning #1647

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions utils/cronjobs_osgeo_lxd/build-xml.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,10 +80,13 @@ def _scandirs(self, path):

def _get_module_files(self, name):
cur_dir = os.getcwd()
os.chdir(os.path.join(self.build_path, name))
files = self._scandirs("*")
os.chdir(cur_dir) # prevent gtask.parse_interface() return None
return files
module_dir = os.path.join(self.build_path, name)
try:
os.chdir(module_dir)
return self._scandirs("*")
finally:
# prevent follow-up failures when cwd is left in a module dir
os.chdir(cur_dir)

def _get_module_metadata(self, name):
path = os.environ["PATH"]
Expand Down
Loading