Skip to content

[19.0][MIG] sale_quotation_builder: Migration to version 19.0 - #397

Merged
OCA-git-bot merged 9 commits into
OCA:19.0from
Tecnativa:19.0-mig-sale_quotation_builder
Aug 25, 2026
Merged

[19.0][MIG] sale_quotation_builder: Migration to version 19.0#397
OCA-git-bot merged 9 commits into
OCA:19.0from
Tecnativa:19.0-mig-sale_quotation_builder

Conversation

@eduezerouali-tecnativa

Copy link
Copy Markdown

Odoo and others added 8 commits August 11, 2026 12:41
…ompany environments

After this commit odoo/odoo@33fd2b1, sale templates have the current company as default.
When installing this module in a database with a multi-company environment and running _set_default_sale_order_template_id_if_empty, a multi-company issue is raised (Incompatible companies on records).
This commit prevents the issue by keeping the company field empty in the default template.
Currently translated at 100.0% (38 of 38 strings)

Translation: sale-reporting-17.0/sale-reporting-17.0-sale_quotation_builder
Translate-URL: https://translation.odoo-community.org/projects/sale-reporting-17-0/sale-reporting-17-0-sale_quotation_builder/it/
Currently translated at 100.0% (38 of 38 strings)

Translation: sale-reporting-17.0/sale-reporting-17.0-sale_quotation_builder
Translate-URL: https://translation.odoo-community.org/projects/sale-reporting-17-0/sale-reporting-17-0-sale_quotation_builder/tr/
Currently translated at 42.1% (16 of 38 strings)

Translation: sale-reporting-17.0/sale-reporting-17.0-sale_quotation_builder
Translate-URL: https://translation.odoo-community.org/projects/sale-reporting-17-0/sale-reporting-17-0-sale_quotation_builder/sl/
@OCA-git-bot OCA-git-bot added series:19.0 mod:sale_quotation_builder Module sale_quotation_builder labels Aug 11, 2026
@eduezerouali-tecnativa
eduezerouali-tecnativa marked this pull request as draft August 11, 2026 14:13
@pedrobaeza

Copy link
Copy Markdown
Member

/ocabot migration sale_quotation_builder

@OCA-git-bot OCA-git-bot added this to the 19.0 milestone Aug 11, 2026
@OCA-git-bot OCA-git-bot mentioned this pull request Aug 11, 2026
14 tasks

@carlos-lopez-tecnativa carlos-lopez-tecnativa left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure whether this error is related to this module, but I edited the default template(In a new company) to add some products. When I tried to select this template in the sales order, I got an access error.

Please check the CI as well.
Image

Image Image

"name": "Test product 1",
"type": "service",
"list_price": 100,
"taxes_id": [(6, 0, [])],

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"taxes_id": [(6, 0, [])],
"taxes_id": [Command.clear()],

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done!

Comment on lines +21 to +57
<!--xpath
expr="//page/field[@name='sale_order_option_ids']/kanban/field[@name='product_id']"
position="after"
>
<field
name="website_description"
invisible="1"
readonly="1"
force_save="1"
/>
</xpath>
<xpath
expr="//page/field[@name='sale_order_option_ids']/form//field[@name='name']"
position="after"
>
<field
name="website_description"
invisible="1"
readonly="1"
force_save="1"
/>
</xpath>
<xpath
expr="//page/field[@name='sale_order_option_ids']/list/field[@name='name']"
position="after"
>
<field
name="website_description"
column_invisible="1"
readonly="1"
force_save="1"
/>
</xpath>

<xpath expr="//button[@name='button_add_to_order']" position="after">
<field name="website_description" invisible="1" />
</xpath-->

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

???

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is why I marked it as draft. Finally removed everything as is not necessary.

@eduezerouali-tecnativa
eduezerouali-tecnativa force-pushed the 19.0-mig-sale_quotation_builder branch from 033f0e8 to b871ba6 Compare August 14, 2026 13:00
@eduezerouali-tecnativa
eduezerouali-tecnativa force-pushed the 19.0-mig-sale_quotation_builder branch from b871ba6 to 413ab84 Compare August 14, 2026 13:03
@eduezerouali-tecnativa
eduezerouali-tecnativa marked this pull request as ready for review August 14, 2026 13:10

@carlos-lopez-tecnativa carlos-lopez-tecnativa left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pedrobaeza pedrobaeza left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code and test in runboat

/ocabot merge nobump

@OCA-git-bot

Copy link
Copy Markdown
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 19.0-ocabot-merge-pr-397-by-pedrobaeza-bump-nobump, awaiting test results.

@OCA-git-bot
OCA-git-bot merged commit 4e675d7 into OCA:19.0 Aug 25, 2026
5 of 7 checks passed
@OCA-git-bot

Copy link
Copy Markdown
Contributor

Congratulations, your PR was merged at 594f47a. Thanks a lot for contributing to OCA. ❤️

@carlos-lopez-tecnativa
carlos-lopez-tecnativa deleted the 19.0-mig-sale_quotation_builder branch August 25, 2026 14:33
Andrii9090-tecnativa pushed a commit to Tecnativa/sale-reporting that referenced this pull request Sep 2, 2026
Signed-off-by pedrobaeza
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants