Skip to content

[FIX] lift_constraints: drop constraints individually, not in one statement #462

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
quoc-pn wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

[FIX] lift_constraints: drop constraints individually, not in one statement #462

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions openupgradelib/openupgrade.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2883,16 +2883,19 @@ def lift_constraints(cr, table, column, cascade=False):
Set cascade=True if other constraints depend on the one you want to delete,
which ie is the case for primary keys.
If everything went right, the constraints will be recreated."""
# PostgreSQL 18 stores NOT NULL as a named constraint in pg_constraint, and
# refuses to drop it while the column is still part of a primary key. Sort
# the primary key first so it is dropped before the not null constraint.
cr.execute(
"select relname, array_agg(conname) from "
"(select t1.relname, c.conname "
"select relname, array_agg(conname order by (contype = 'p') desc) from "
"(select t1.relname, c.conname, c.contype "
"from pg_constraint c "
"join pg_attribute a "
"on c.confrelid=a.attrelid and a.attnum=any(c.conkey) "
"join pg_class t on t.oid=a.attrelid "
"join pg_class t1 on t1.oid=c.conrelid "
"where t.relname=%(table)s and attname=%(column)s "
"union select t.relname, c.conname "
"union select t.relname, c.conname, c.contype "
"from pg_constraint c "
"join pg_attribute a "
"on c.conrelid=a.attrelid and a.attnum=any(c.conkey) "
Expand Down
Loading