[18.0][IMP] website_sale_product_minimal_price: performance improvements - #1302
Open
jans23 wants to merge 1 commit into
Open
[18.0][IMP] website_sale_product_minimal_price: performance improvements#1302jans23 wants to merge 1 commit into
jans23 wants to merge 1 commit into
Conversation
`_get_cheapest_info` iterated over every variant of every template, which forced a per-record compute of the non-stored `price_extra` field and a contextual price computation for each variant. This is very slow for products with many variants. * When there are no per-variant pricelist rules, the price is monotonic in `price_extra`, so only the base, min-extra and max-extra variants can be the cheapest. Price only those instead of all variants. * Read `price_extra` for all variants via a single grouped SQL query (`_get_variants_price_extra_map`) instead of the per-record ORM compute, and prefetch it once per page in `_get_sales_prices`. No request-scoped caching is added because profiling showed `_get_cheapest_info` is called at most once per template per request, so a cache never yields a hit and only adds complexity.
Contributor
|
Hi @sergio-teruel, |
OCA-git-bot
added
series:18.0
mod:website_sale_product_minimal_price
pedrobaeza
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
_get_cheapest_infoiterated over every variant of every template, which forced a per-record compute of the non-storedprice_extrafield and a contextual price computation for each variant. This is very slow for products with many variants.price_extra, so only the base, min-extra and max-extra variants can be the cheapest. Price only those instead of all variants.price_extrafor all variants via a single grouped SQL query (_get_variants_price_extra_map) instead of the per-record ORM compute, and prefetch it once per page in_get_sales_prices.No request-scoped caching is added because profiling showed
_get_cheapest_infois called at most once per template per request, so a cache never yields a hit and only adds complexity.