[19.0][MIG] website_sale_product_matrix: Migration to version 19.0 - #1301
Conversation
Currently translated at 100.0% (8 of 8 strings) Translation: e-commerce-15.0/e-commerce-15.0-website_sale_product_matrix Translate-URL: https://translation.odoo-community.org/projects/e-commerce-15-0/e-commerce-15-0-website_sale_product_matrix/es/
cabea64 to
9067146
Compare
…product matrix TT61122
Currently translated at 100.0% (8 of 8 strings) Translation: e-commerce-17.0/e-commerce-17.0-website_sale_product_matrix Translate-URL: https://translation.odoo-community.org/projects/e-commerce-17-0/e-commerce-17-0-website_sale_product_matrix/ca/
Currently translated at 100.0% (8 of 8 strings) Translation: e-commerce-17.0/e-commerce-17.0-website_sale_product_matrix Translate-URL: https://translation.odoo-community.org/projects/e-commerce-17-0/e-commerce-17-0-website_sale_product_matrix/es/
Currently translated at 100.0% (7 of 7 strings) Translation: e-commerce-17.0/e-commerce-17.0-website_sale_product_matrix Translate-URL: https://translation.odoo-community.org/projects/e-commerce-17-0/e-commerce-17-0-website_sale_product_matrix/it/
Currently translated at 100.0% (8 of 8 strings) Translation: e-commerce-17.0/e-commerce-17.0-website_sale_product_matrix Translate-URL: https://translation.odoo-community.org/projects/e-commerce-17-0/e-commerce-17-0-website_sale_product_matrix/es/
Currently translated at 100.0% (8 of 8 strings) Translation: e-commerce-17.0/e-commerce-17.0-website_sale_product_matrix Translate-URL: https://translation.odoo-community.org/projects/e-commerce-17-0/e-commerce-17-0-website_sale_product_matrix/ca/
Currently translated at 100.0% (7 of 7 strings) Translation: e-commerce-17.0/e-commerce-17.0-website_sale_product_matrix Translate-URL: https://translation.odoo-community.org/projects/e-commerce-17-0/e-commerce-17-0-website_sale_product_matrix/it/
…atrix products The matrix add mode was hiding the standard variant selector by adding a `t-if` on the `select` placeholder. This removed the whole block from the DOM, including the hidden `product_id` / `product_template_id` inputs and the standard variant selection data. This breaks features that rely on the selected variant being available in the website product page, such as the dynamic alternative products filter. When the selector is not rendered, there is no selected variant/product context for the filter to use, so alternative products are not found. Instead of removing the selector, keep it rendered and only add `d-none` to the variant list through `ul_class` when the product uses matrix mode. This keeps the standard website_sale data available for frontend widgets while preserving the matrix UI as the visible product configurator. TT62939
9067146 to
90326c4
Compare
|
/ocabot migration website_sale_product_matrix |
90326c4 to
8cc4505
Compare
|
@pedrobaeza could you please review it? |
pedrobaeza
left a comment
There was a problem hiding this comment.
Testing it on runboat, one problem I see is if you wishlist the template, on the wishlist view, you don't have the matrix on it, but the regular configurator one, but I suppose this problem also exists in the previous version, and it will require a website_sale_wishlist_product_matrix glue module. Just mention it in the ROADMAP.
86a3d80 to
f4a6567
Compare
Added it to the ROADMAP. |
|
/ocabot merge nobump |
|
Hey, thanks for contributing! Proceeding to merge this for you. |
|
Congratulations, your PR was merged at a99c7fe. Thanks a lot for contributing to OCA. ❤️ |
add-to-cartbutton moved out ofwebsite_sale.productinto a newwebsite_sale.cta_wrappertemplate, so the "Configure options" button/hiddenadd-to-cartxpaths were moved there too.-placeholder="select", so the xpath hiding it was adjusted accordingly.website_sale.add_to_cart_redirectno longer exists in 19.0 (removed along with it), so the template and JS code relying on it (product-add-modehtml attribute /stayOnPageOption) were dropped as dead code.website.sale_get_order()was replaced byrequest.cart/website._create_cart()in the controller and in the matrix modal template.publicWidget.registry.WebsiteSalewidget was removed in 19.0, so the JS was rewritten as its own small widget instead of extending it.@Tecnativa TT64162
@pedrobaeza @pilarvargas-tecnativa