Skip to content

[19.0][MIG] website_sale_wishlist_keep: Migration to version 19.0 - #1291

Open
cristina-hidalgo-tecnativa wants to merge 20 commits into
OCA:19.0from
Tecnativa:19.0-mig-website_sale_wishlist_keep
Open

[19.0][MIG] website_sale_wishlist_keep: Migration to version 19.0#1291
cristina-hidalgo-tecnativa wants to merge 20 commits into
OCA:19.0from
Tecnativa:19.0-mig-website_sale_wishlist_keep

Conversation

@cristina-hidalgo-tecnativa

@cristina-hidalgo-tecnativa cristina-hidalgo-tecnativa commented Aug 18, 2026

Copy link
Copy Markdown
Contributor

Odoo 19 removed the #b2b_wish checkbox and its JS logic from website_sale_wishlist; adding a product to cart from the wishlist now always removes it, with no built-in option. This module restores that checkbox and its original behavior:

  • Add back the #b2b_wish checkbox on the wishlist page (removed upstream in b414047).
  • Add a JS patch on ProductWishlist reproducing the removed core condition (if (quantity > 0 && !checkbox.checked) removeProduct()).
  • Keep the customize_show view that pre-checks it by default, now exposed from the new Style tab (Wishlist Page section) instead of the old Customize tab.
  • Update tour and tests accordingly.

@Tecnativa TT64171
@pedrobaeza @pilarvargas-tecnativa

@OCA-git-bot OCA-git-bot added series:19.0 mod:website_sale_wishlist_keep Module website_sale_wishlist_keep labels Aug 18, 2026
@pedrobaeza

Copy link
Copy Markdown
Member

/ocabot migration website_sale_wishlist_keep

@cristina-hidalgo-tecnativa
cristina-hidalgo-tecnativa force-pushed the 19.0-mig-website_sale_wishlist_keep branch 2 times, most recently from e184fa4 to 8384683 Compare August 18, 2026 07:58

@Andrii9090-tecnativa Andrii9090-tecnativa left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, test on runboat 👍

@pilarvargas-tecnativa pilarvargas-tecnativa left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please restore the Odoo option in this module to how it was in previous versions

@pedrobaeza

Copy link
Copy Markdown
Member

Use odoo/odoo@b414047 as reference

@adasatorres-tecnativa adasatorres-tecnativa left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Code review and functionality testing on Runboat.

@BhaveshHeliconia BhaveshHeliconia left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional review LGTM!

@pedrobaeza

Copy link
Copy Markdown
Member

ping @pilarvargas-tecnativa

@pilarvargas-tecnativa pilarvargas-tecnativa left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you update the PR description? The current implementation restores the #b2b_wish checkbox, so the data-keep-wishlist explanation is outdated.

Comment thread website_sale_wishlist_keep/readme/DESCRIPTION.md Outdated
Comment thread website_sale_wishlist_keep/static/src/js/product_wishlist_patch.esm.js Outdated

@pilarvargas-tecnativa pilarvargas-tecnativa left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The option needs to be moved in the editor, as it's disrupting the product design.

Image

@cristina-hidalgo-tecnativa
cristina-hidalgo-tecnativa force-pushed the 19.0-mig-website_sale_wishlist_keep branch from cf4538c to d837366 Compare August 26, 2026 09:54
@cristina-hidalgo-tecnativa

Copy link
Copy Markdown
Contributor Author

The option needs to be moved in the editor, as it's disrupting the product design.
Image

Modified.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

mod:website_sale_wishlist_keep Module website_sale_wishlist_keep series:19.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.