[19.0][MIG] website_sale_vat_required: Migration to 19.0 - #1264
[19.0][MIG] website_sale_vat_required: Migration to 19.0#1264ManfredNelvin-Dev wants to merge 24 commits into
Conversation
OCA-git-bot
added
series:19.0
mod:website_sale_vat_required
f1d306e to
d1aed26
Compare
There was a problem hiding this comment.
Tested locally and LGTM.
The CI error is caused by this PR being the first to bring base_vat into the CI database, which exposes an invalid VAT number in website_sale_require_legal's tour — already fixed here .
A rebase of the branch should make the tests pass.
TT64169
|
@ManfredNelvin-Dev can you rebase? /ocabot migration website_sale_vat_required |
[FIX] Depend on vat validation module that causes the VAT number field to be displayed at checkout in the first place
This addon got migrated from 8.0. Relevant notes: - Moved from `OCA/website` to `OCA/e-commerce`. - Reduced license headers to new style ones, keeping copyright. - Updated README template. - Replaced dirty hack that disables addon in test mode, and hack the tour instead (actually testing the addon). - Benefit from upstream updates, that now handles incorrect VAT errors.
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: e-commerce-12.0/e-commerce-12.0-website_sale_vat_required Translate-URL: https://translation.odoo-community.org/projects/e-commerce-12-0/e-commerce-12-0-website_sale_vat_required/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: e-commerce-13.0/e-commerce-13.0-website_sale_vat_required Translate-URL: https://translation.odoo-community.org/projects/e-commerce-13-0/e-commerce-13-0-website_sale_vat_required/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: e-commerce-15.0/e-commerce-15.0-website_sale_vat_required Translate-URL: https://translation.odoo-community.org/projects/e-commerce-15-0/e-commerce-15-0-website_sale_vat_required/
…hods in test Modify the tests so that we don't have to rely on the payment methods module to run the tests for the functionality of this module. TT44388
The tests were using a demo data product so if at any time this product does not exist the tests start to fail. To avoid this, a new product is created and used for testing. Also to locate the checkout button it is better to locate it by its container element as the classes can change depending on the configuration and modules used in the instance and it can be a problem to locate it.
Adapt according to this commit: odoo/odoo@453cfab
d1aed26 to
182f702
Compare
|
@cristina-hidalgo-tecnativa Thank you for testing it locally and for the review. @pedrobaeza I have rebased the branch on the latest 19.0 and force-pushed the changes. The CI is now passing. |
pedrobaeza
left a comment
pedrobaeza
left a comment
There was a problem hiding this comment.
@ManfredNelvin several comments apart from the inline one:
- The migration commit shouldn't include
[19.0]as prefix. - Please squash into this one the other commit
[IMP] website_sale_vat_required: Adapt tests for Odoo 19, as that's part of the migration.
182f702 to
2460d12
Compare
|
@pedrobaeza Thanks for the review. I have squashed the test adaptation changes into the migration commit, updated the commit message to follow the migration convention, removed the extra blank line, and force-pushed the branch. |
2460d12 to
84605fa
Compare
pedrobaeza
left a comment
pedrobaeza
left a comment
There was a problem hiding this comment.
On a test in runboat, the field is not marked with *:
If I try to continue without filling VAT, the message appears, and then the field gets the *.
Is it possible to get it from the beginning?
| @@ -1 +1,3 @@ | |||
| # Copyright 2019 Tecnativa - Ernesto Tejeda | |||
There was a problem hiding this comment.
init files don't have copyright
19 participants
Migration of
website_sale_vat_requiredto Odoo 19.0.