Skip to content

[FIX] hr_recruitment: fix lift_constraints() constraint drop order for PostgreSQL 17+ #5884

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
quoc-pn wants to merge 1 commit into from
Closed

[FIX] hr_recruitment: fix lift_constraints() constraint drop order for PostgreSQL 17+ #5884

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 13 additions & 3 deletions openupgrade_scripts/scripts/hr_recruitment/19.0.1.1/pre-migration.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,10 +13,20 @@ def hr_candidate2hr_applicant(env):
"""
openupgrade.merge_models(env.cr, "hr.candidate", "hr.applicant", "candidate_id")
openupgrade.rename_tables(env.cr, [("hr_candidate", None)])
openupgrade.lift_constraints(
env.cr, openupgrade.get_legacy_name("hr_candidate"), "id", cascade=True
legacy_table = openupgrade.get_legacy_name("hr_candidate")
# PostgreSQL >= 17 catalogs NOT NULL as a named constraint and refuses to
# drop it while the column is still part of a primary key, even when the
# pkey drop is queued in the same ALTER TABLE statement (as
# openupgrade.lift_constraints does). Drop the pkey first, on its own, so
# the remaining lift_constraints() call only has the not-null constraint
# left to lift.
env.cr.execute(
"alter table {} drop constraint if exists {} cascade".format(
legacy_table, legacy_table + "_pkey"
)
)
openupgrade.remove_tables_fks(env.cr, [openupgrade.get_legacy_name("hr_candidate")])
openupgrade.lift_constraints(env.cr, legacy_table, "id", cascade=True)
openupgrade.remove_tables_fks(env.cr, [legacy_table])


@openupgrade.migrate()
Expand Down
Loading