Add package staging schema and status support by japarson · Pull Request #10918 · NuGet/NuGetGallery

japarson · 2026-07-29T02:41:12Z

Schema and entity groundwork for package staging. No behavior change.

Adds StagingGroup, StagedPackage, and StagingBlobCleanup entities and DbSets.
Adds PackageStatus.Staged hidden from all public surfaces.
Adds Package.ApproverUserKey to record who promoted a package, separate from who pushed it.
Adds User.StagingPackageLimit for per-account staged package quota.
Single migration AddPackageStaging: 3 tables, 2 columns, 5 indexes, 5 FKs.
Account deletion removes the account's staging groups and staged packages, and queues their blobs for cleanup.

Copilot

Pull request overview

This PR lays the schema + entity groundwork for “package staging” in NuGetGallery, introducing new staging tables/entities and wiring a new hidden PackageStatus.Staged through the data model and a few internal code paths, without enabling end-user staging behavior yet.

Changes:

Add new staging entities (StagingGroup, StagedPackage, StagingBlobCleanup) plus EF model configuration and a migration (AddPackageStaging).
Introduce PackageStatus.Staged (and PackageStatusSummary.Staged) and update view-model/status handling and related tests.
Extend account deletion to remove staging-owned data and record promotion identity via Package.ApproverUserKey.

Show a summary per file

File	Description
tests/NuGetGallery.Facts/ViewModels/PackageViewModelFacts.cs	Adds test coverage for mapping `PackageStatus.Staged` to a status summary; strengthens “unexpected status” test value.
tests/NuGetGallery.Facts/TestUtils/FakeEntitiesContext.cs	Extends the fake EF context with DbSets for new staging entities.
tests/NuGetGallery.Facts/Services/DeleteAccountServiceFacts.cs	Adds assertions + test data for staging cleanup and for removing package approver references during deletion.
tests/NuGet.Services.Entities.Tests/StagedValidationStatusFacts.cs	New test intended to lock enum integer values for persisted `StagedValidationStatus`.
tests/NuGet.Services.Entities.Tests/PackageStatusFacts.cs	Appends `PackageStatus.Staged` to the immutable value test map.
tests/NuGet.Services.AzureSearch.Tests/DatabaseAuxiliaryDataFetcherFacts.cs	Updates test context stub to satisfy expanded `IEntitiesContext` contract.
src/VerifyMicrosoftPackage/Fakes/FakeEntitiesContext.cs	Updates stub context to satisfy expanded `IEntitiesContext` contract.
src/NuGetGallery/ViewModels/PackageStatusSummary.cs	Adds `PackageStatusSummary.Staged` enum value with display description.
src/NuGetGallery/NuGetGallery.csproj	Adds the new EF migration artifacts to the legacy explicit-compile project file.
src/NuGetGallery/Migrations/202607290027439_AddPackageStaging.resx	Adds migration resource payload for EF6 metadata.
src/NuGetGallery/Migrations/202607290027439_AddPackageStaging.Designer.cs	Adds EF-generated migration metadata class.
src/NuGetGallery/Migrations/202607290027439_AddPackageStaging.cs	Adds migration creating staging tables + new columns/index/foreign key for approver tracking.
src/NuGetGallery/Helpers/ViewModelExtensions/PackageViewModelFactory.cs	Maps `PackageStatus.Staged` to the new `PackageStatusSummary.Staged`.
src/NuGetGallery/Controllers/PackagesController.cs	Excludes staged packages from the symbols-deletion flow’s candidate set.
src/NuGetGallery.Services/AccountManagement/DeleteAccountService.cs	Removes staging-owned rows on account deletion; clears package approver references; enqueues staged blobs for deferred cleanup.
src/NuGetGallery.Core/Entities/IEntitiesContext.cs	Extends the EF context interface with staging DbSets.
src/NuGetGallery.Core/Entities/EntitiesContext.cs	Adds DbSets + EF model configuration for staging entities and `Package.ApproverUser` relationship.
src/NuGet.Services.Entities/User.cs	Adds per-account staged package quota (`StagingPackageLimit`).
src/NuGet.Services.Entities/StagingGroup.cs	New entity defining owner-scoped staging groups.
src/NuGet.Services.Entities/StagingBlobCleanup.cs	New table-as-queue entity for deferred deletion of staging blobs.
src/NuGet.Services.Entities/StagedValidationStatus.cs	New enum representing validation progress while a package remains in `Staged`.
src/NuGet.Services.Entities/StagedPackage.cs	New entity holding ephemeral staging metadata for a staged package.
src/NuGet.Services.Entities/PackageStatus.cs	Adds `PackageStatus.Staged` with documentation indicating it’s non-public/hidden.
src/NuGet.Services.Entities/Package.cs	Adds `ApproverUser`/`ApproverUserKey` to record who promoted a staged package.

Review details

Files not reviewed (1)

src/NuGetGallery/Migrations/202607290027439_AddPackageStaging.Designer.cs: Generated file

Files reviewed: 23/24 changed files
Comments generated: 2
Review effort level: Lite

+// Copyright (c) .NET Foundation. All rights reserved.
+// Licensed under the Apache License, Version 2.0. See License.txt in the project root for license information.
+
+using Xunit;


+                package.ApproverUser = null;
+            }


chabiss · 2026-07-31T16:36:43Z

@@ -0,0 +1,105 @@
+namespace NuGetGallery.Migrations


space NuGetGallery.Migrations

Are those files Generated? These should be a header that said that those files are generated by a specific tool? Otherwise, header is missing

chabiss

agr · 2026-08-03T20:36:58Z

+        /// <summary>
+        /// Gets or sets the primary key for the entity.
+        /// </summary>
+        public int Key { get; set; }


If we are not going to have multiple entries in this table for an entry in Packages table, can we just use PackageKey here as primary key and drop this column?
Is there a scenario where look up in this table would be done NOT by package key?

I'm still refining the design so hold off on reviewing until I republish the PR.

agr · 2026-08-03T20:39:39Z

+        public int PackageKey { get; set; }
+
+        /// <summary>
+        /// Gets or sets the staged package.


Gets or sets? It should be a navigation property value of which defined by PackageKey.

agr · 2026-08-03T20:41:06Z

+        /// <summary>
+        /// Gets or sets the user or organization that owns this staged package.
+        /// </summary>
+        public virtual User Owner { get; set; }


Package ownership right now happens on package registration level and there might be multiple owners. How that property fits into existing ownership setup?

agr · 2026-08-03T20:43:48Z

+
+        /// <summary>
+        /// Gets or sets the path to the nupkg in the private staging container. The path embeds a GUID so that
+        /// deleting and re-uploading the same id and version cannot collide with the outgoing blob.


If deleting leaves a chance for the blob to stay, what's the plan to clean up the storage from stale entries?

agr · 2026-08-03T20:44:07Z

+        /// this mirrors the group's expiration; for ungrouped packages it is set at push time and reset on replace.
+        /// The timestamp is in UTC.
+        /// </summary>
+        public DateTime ExpirationDate { get; set; }


What happens on expiration?

agr · 2026-08-03T20:47:05Z

+        /// Gets or sets how far validation has got for this package. A staged package stays in
+        /// <see cref="PackageStatus.Staged"/> throughout, so this is the only signal that it is promotable.
+        /// </summary>
+        public StagedValidationStatus ValidationStatus { get; set; }


Don't we need 2 statuses here: one for regular package, another for symbols?
Why not reuse status columns in Packages/SymbolPackages tables? No state duplication, less code changes to make.

agr · 2026-08-03T20:48:57Z

+        /// Gets or sets the key of the group this package belongs to, or <c>null</c> if the package is ungrouped.
+        /// When set, the group's owner must match <see cref="OwnerKey"/>.
+        /// </summary>
+        public int? StagingGroupKey { get; set; }


Can a package be staged to multiple groups at the same time?

agr · 2026-08-03T21:03:40Z

+                .Index(t => t.PackageKey, unique: true)
+                .Index(t => t.OwnerKey)
+                .Index(t => t.StagingGroupKey)
+                .Index(t => t.ExpirationDate);


Single column indexes are not very useful: we are not going to be doing just single value operations with those, right? Additional columns should be included based on data that is actually retrieved using those indexes.

Depending how heavily the feature is used it might not matter much.

Add package staging schema and status support

8b3eb0f

japarson requested a review from a team as a code owner July 29, 2026 02:41

Add staged validation status tracking

4a74929

japarson force-pushed the japarson/staging-db branch from 2238a54 to 4a74929 Compare July 30, 2026 17:50

japarson marked this pull request as draft July 30, 2026 22:49

chabiss requested a review from Copilot July 31, 2026 16:30

Copilot started reviewing on behalf of chabiss July 31, 2026 16:31 View session

Copilot AI reviewed Jul 31, 2026

View reviewed changes

chabiss reviewed Jul 31, 2026

View reviewed changes

chabiss approved these changes Jul 31, 2026

View reviewed changes

agr reviewed Aug 3, 2026

View reviewed changes

Navigation Menu

Uh oh!

Add package staging schema and status support - #10918

Add package staging schema and status support#10918
japarson wants to merge 2 commits into
feature/stagingfrom
japarson/staging-db

japarson commented Jul 29, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

chabiss Jul 31, 2026

Uh oh!

chabiss left a comment

Uh oh!

agr Aug 3, 2026 •

edited

Loading

Uh oh!

japarson Aug 3, 2026

Uh oh!

agr Aug 3, 2026

Uh oh!

agr Aug 3, 2026

Uh oh!

agr Aug 3, 2026

Uh oh!

agr Aug 3, 2026

Uh oh!

agr Aug 3, 2026

Uh oh!

agr Aug 3, 2026

Uh oh!

agr Aug 3, 2026

Uh oh!

agr Aug 3, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

japarson commented Jul 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Review details

Uh oh!

Choose a reason for hiding this comment

Uh oh!

chabiss left a comment

Choose a reason for hiding this comment

Uh oh!

agr Aug 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

japarson commented Jul 29, 2026 •

edited

Loading

agr Aug 3, 2026 •

edited

Loading