fix(js-x-ray): measure scrypt salt in bytes and merge warnings into one per call - #707
Merged
fraxken merged 3 commits intoSep 16, 2026
Conversation
HoyeongJeon
commented
Sep 14, 2026
HoyeongJeon
commented
Contributor
- The i18n messages say that the code checked in bytes but it actually checked in chars, so I fixed the code to check in bytes.
- When it has several warnings at once, I merge them into one per call.
馃 Changeset detectedLatest commit: 3507036 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
PierreDemailly
approved these changes
Sep 14, 2026
clemgbld
approved these changes
Sep 16, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.