Skip to content

tlottie: fix dylib install name on Darwin - #563376

Merged
NickCao merged 1 commit into
NixOS:masterfrom
r4v3n6101:tlottie-darwin
Sep 15, 2026
Merged

NickCao merged 1 commit into
NixOS:masterfrom
r4v3n6101:tlottie-darwin

Conversation

@r4v3n6101

@r4v3n6101 r4v3n6101 commented Sep 14, 2026

Copy link
Copy Markdown
Member

Things done

Fix linking into temporary build directory. Tested in telegram-desktop that uses the library.

@r4v3n6101
r4v3n6101 requested a review from NickCao September 14, 2026 23:46
@nixpkgs-ci nixpkgs-ci Bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Sep 14, 2026
@NickCao

NickCao commented Sep 14, 2026

Copy link
Copy Markdown
Member

So telegram-desktop is failing to launch on darwin without this fix?

@r4v3n6101

Copy link
Copy Markdown
Member Author

Yeah, it just crashes with Send report to Apple menu.

@NickCao
NickCao added this pull request to the merge queue Sep 15, 2026
@NickCao

NickCao commented Sep 15, 2026

Copy link
Copy Markdown
Member

Send report to Apple

Hope we haven't bothered them with too many reports 😅

Merged via the queue into NixOS:master with commit 2cfa652 Sep 15, 2026
30 checks passed
@booxter booxter mentioned this pull request Sep 16, 2026
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants