python3Packages.vegafusion: patch failing tests - #543893
Merged
Merged
Conversation
wariuccio
force-pushed
the
vegafusion-tests
branch
from
July 20, 2026 15:39
eae1d82 to
721c65f
Compare
nixpkgs-ci
Bot
added
10.rebuild-linux: 1-10
mdaniels5757
requested changes
Jul 20, 2026
nixpkgs-ci
Bot
removed
the
9.needs: reviewer
wariuccio
force-pushed
the
vegafusion-tests
branch
from
July 21, 2026 00:07
721c65f to
744520c
Compare
Member
|
mdaniels5757
approved these changes
Jul 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed that the package fails to build on NixOS because of changes on an underlying library. I am trying to upstream the fix vega/vegafusion#592 but in the meantime we can fix the package by applying as a patch the content of the PR I opened.
Things done
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.