Skip to content

refactor(js): centralize page bootstrapping into single DOMContentLoaded handler #646

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jbampton merged 4 commits into from
Oct 4, 2026
Merged

refactor(js): centralize page bootstrapping into single DOMContentLoaded handler #646

Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
fa7e110
refactor(js): centralize page bootstrapping into single DOMContentLoa…
titas-mahato Oct 3, 2026
af6784e
fix: inline bootstrap logic to prevent global scope pollution
titas-mahato Oct 3, 2026
fe1fc13
refactor: wrap bootstrap helpers locally to satisfy complexity checks
titas-mahato Oct 3, 2026
03348fa
fix: remove redundant unlockedEggs declaration to resolve shadowing
titas-mahato Oct 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
78 changes: 41 additions & 37 deletions src/assets/js/script.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1430,49 +1430,53 @@ function finalizeFooterDot(core, ping) {
document.getElementById("footer-surge-button").style.cursor = "default";
}

// Re-initialize skills after Surprise scroll or any DOM changes
window.addEventListener("DOMContentLoaded", () => {
initSkillXP();

const unlockedEggs = JSON.parse(localStorage.getItem("unlockedEggs") || "[]");
if (unlockedEggs.includes("footer_surge")) {
finalizeFooterDot(
document.getElementById("footer-dot-core"),
document.getElementById("footer-dot-ping"),
);
}
});

/**
* INITIALIZATION
*/
document.addEventListener("DOMContentLoaded", () => {
const devToolsVisible = localStorage.getItem("devToolsVisible") === "true";
const devPanel = document.getElementById("dev-tools");

if (devToolsVisible && devPanel) {
devPanel.classList.remove("hidden");
(() => {
function initFooterSurgeState() {
const unlockedEggs = JSON.parse(localStorage.getItem("unlockedEggs") || "[]");

@deepsource-io deepsource-io Bot Oct 3, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'unlockedEggs' is already declared in the upper scope on line 20 column 7


Two variables can have the same name if they're declared in different scopes. In the example below, the parameter x is said to "shadow" the variable x declared above it. The outer x can no longer be accessed inside the sum function.

if (unlockedEggs.includes("footer_surge")) {
finalizeFooterDot(
document.getElementById("footer-dot-core"),
document.getElementById("footer-dot-ping"),
);
}
}

const container = document.getElementById("matrix-console-container");
const reopenBtn = document.getElementById("reopen-console-btn");
function initConsoleState() {
const devToolsVisible = localStorage.getItem("devToolsVisible") === "true";
const devPanel = document.getElementById("dev-tools");

// Force closed state on load
if (container) {
container.classList.add("hidden");
container.style.opacity = "0";
container.style.transform = "translateY(20px)";
}
if (devToolsVisible && devPanel) {
devPanel.classList.remove("hidden");
}

if (reopenBtn) {
reopenBtn.classList.remove("hidden");
}
const container = document.getElementById("matrix-console-container");
const reopenBtn = document.getElementById("reopen-console-btn");

initDotEasterEgg();
initSkillMining();
// Initialize the profile counter
initProfileTracker();
// Force closed state on load
if (container) {
container.classList.add("hidden");
container.style.opacity = "0";
container.style.transform = "translateY(20px)";
}

applyTheme(localStorage.getItem("theme") || "light");
updateGameUI();
});
if (reopenBtn) {
reopenBtn.classList.remove("hidden");
}
}

document.addEventListener("DOMContentLoaded", () => {
initSkillXP();
initFooterSurgeState();
initConsoleState();
initDotEasterEgg();
initSkillMining();
// Initialize the profile counter
initProfileTracker();

applyTheme(localStorage.getItem("theme") || "light");
updateGameUI();
});
})();