Skip to content

DOC use TLCenter for example on RPA - #1174

Open
qbarthelemy wants to merge 3 commits into
NeuroTechX:developfrom
qbarthelemy:tlcenter
Open

DOC use TLCenter for example on RPA#1174
qbarthelemy wants to merge 3 commits into
NeuroTechX:developfrom
qbarthelemy:tlcenter

Conversation

@qbarthelemy

Copy link
Copy Markdown
Contributor

@bruAristimunha

Copy link
Copy Markdown
Collaborator

thanks again for this @qbarthelemy 🙏🏽

@bruAristimunha

Copy link
Copy Markdown
Collaborator

FYI: some simplification in the riemannian alignment @toncho11

@bruAristimunha
bruAristimunha enabled auto-merge (squash) September 5, 2026 08:16
@toncho11

toncho11 commented Sep 5, 2026

Copy link
Copy Markdown
Collaborator

I am not sure, but I think there may be a semantic issue in fit_transform().

The previous code centered each source subject independently, while the new code calls TLCenter.transform(), which uses only the target-domain center. TLCenter explicitly documents that fit_transform() and fit().transform() have different semantics: https://pyriemann.readthedocs.io/en/latest/generated/pyriemann.transfer.TLCenter.html

I think this must be investigated before merging.

@toncho11
toncho11 disabled auto-merge September 7, 2026 07:37
@qbarthelemy

Copy link
Copy Markdown
Contributor Author

@toncho11 is right.
I fixed fit_transform so that it correctly re-centers each domain.

@toncho11

toncho11 commented Sep 7, 2026

Copy link
Copy Markdown
Collaborator

Looks OK. Did you check if the results are similar between the old and the new version?

@qbarthelemy

Copy link
Copy Markdown
Contributor Author

Yes, I had checked.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants