Skip to content

fix(eth2util): sort deposit-data listing, seed keystore uuids from rng - #656

Merged
iamquang95 merged 1 commit into
mainfrom
feat/fix-627-3
Aug 21, 2026
Merged

fix(eth2util): sort deposit-data listing, seed keystore uuids from rng#656
iamquang95 merged 1 commit into
mainfrom
feat/fix-627-3

Conversation

@iamquang95

Copy link
Copy Markdown
Collaborator

Fix #627

  • Sort the deposit-data file listing. read_dir order is filesystem-dependent, so an index could mean a different amount on another machine. Matches charon's sorted glob.
  • Draw keystore uuids from the rng parameter instead of Uuid::new_v4(), which silently bypassed it. Seeded keystores are now reproducible.
  • Deliberate deviations from charon (comments explain local rationale only): strict withdrawal_credentials length check, zero-sig before domain resolution, SSE slot saturation, exit fork version from the BN spec, v4 bits on keystore uuids, escaped . in the keystore regex.

Comment thread crates/eth2util/src/keystore/store.rs Dismissed
@iamquang95
iamquang95 merged commit 05c5c40 into main Aug 21, 2026
19 of 20 checks passed
@iamquang95
iamquang95 deleted the feat/fix-627-3 branch August 21, 2026 02:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Beacon-node version-check parity, privkeylock interop, and fix-or-document divergences

3 participants