fix(eth2util): sort deposit-data listing, seed keystore uuids from rng - #656
Merged
Conversation
varex83
approved these changes
Aug 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #627
read_dirorder is filesystem-dependent, so an index could mean a different amount on another machine. Matches charon's sorted glob.rngparameter instead ofUuid::new_v4(), which silently bypassed it. Seeded keystores are now reproducible.withdrawal_credentialslength check, zero-sig before domain resolution, SSE slot saturation, exit fork version from the BN spec, v4 bits on keystore uuids, escaped.in the keystore regex.