fix(app): serialize privkeylock timestamps as RFC3339 - #655
Open
iamquang95 wants to merge 1 commit into
Open
Conversation
varex83
approved these changes
Aug 19, 2026
emlautarom1
approved these changes
Aug 19, 2026
emlautarom1
left a comment
emlautarom1
left a comment
Collaborator
There was a problem hiding this comment.
serializes byte-identically to Go
Not exactly since Go's serialization trims trailing zeros unlike chrono. Works either way, but it's not byte-identical.
The
u64format never shipped
It did though (we used this format so far).
Code looks good, the PR body might be a bit misleading though.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix "privkeylock: the two implementations can't see each other's locks" in #627
Metadata.timestampwasu64unix seconds; charon writes Go time.Time (RFC3339). A shared --private-key-file-lock path gave a JSON decode error instead of "another charon instance may be running".Switched to
chrono::DateTime<Utc>, which serializes byte-identically to Go. Theu64format never shipped. Staleness compare is now sub-second, matchingtime.Since.