-
Notifications
You must be signed in to change notification settings - Fork 720
test: load the frame transaction fixtures by mapping their fork name #12854
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Marchhill
merged 4 commits into
eip8141-frame-txs-devnet7
from
claude/eip8141-fixture-suite
Aug 19, 2026
+56
−8
Merged
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
ed23eca
test: load the frame transaction fixtures by mapping their fork name
Marchhill 35ce825
Merge remote-tracking branch 'upstream/eip8141-frame-txs-devnet7' int…
Marchhill 692f477
test: chain both shape errors and name the resolved fork
Marchhill 89200dc
test: forward the string fixture overload to the span one
Marchhill File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
27 changes: 27 additions & 0 deletions
27
src/Nethermind/Nethermind.Specs.Test/SpecNameParserTests.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,27 @@ | ||
| // SPDX-FileCopyrightText: 2026 Demerzel Solutions Limited | ||
| // SPDX-License-Identifier: LGPL-3.0-only | ||
|
|
||
| using System; | ||
| using Nethermind.Core.Specs; | ||
| using NUnit.Framework; | ||
|
|
||
| namespace Nethermind.Specs.Test; | ||
|
|
||
| public class SpecNameParserTests | ||
| { | ||
| [Test] | ||
| public void Parse_maps_Bogota_to_the_frame_transactions_fork() | ||
| { | ||
| IReleaseSpec spec = SpecNameParser.Parse("Bogota"); | ||
|
|
||
| Assert.That(spec.IsEip8141Enabled, Is.True); | ||
|
Marchhill marked this conversation as resolved.
Outdated
|
||
| } | ||
|
|
||
| [Test] | ||
| public void Parse_names_the_offending_fork_when_unmapped() | ||
| { | ||
| NotSupportedException e = Assert.Throws<NotSupportedException>(() => SpecNameParser.Parse("NotAFork")); | ||
|
|
||
| Assert.That(e.Message, Does.Contain("NotAFork")); | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.