Experiment: Enable bloom filters for PebbleDB - #3949
Draft
brbrr wants to merge 2 commits into
Draft
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3949 +/- ##
==========================================
- Coverage 74.99% 74.59% -0.41%
==========================================
Files 446 461 +15
Lines 40312 41111 +799
==========================================
+ Hits 30233 30665 +432
- Misses 7967 8336 +369
+ Partials 2112 2110 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Contributor
|
Why is there regressing values? I would expect performance to stay the same at worst? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an experiment that enables bloom filters for pebble SSTables. The tricky part of this is that to populate the blooms on SSTables, the DB table needs to be written to. To effectively add blooms, we need to run a compaction across all the tables. It's quite a long-running process (>6h).
Here are preliminary results of the bench run (comparing dbs with and without blooms populated):