Skip to content

cuda: don't flush CUDA feature extractors twice when a thread pool is present #1553

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
BardieJoensen wants to merge 1 commit into
base: master
Choose a base branch
from
+6 −0
Open

cuda: don't flush CUDA feature extractors twice when a thread pool is present #1553

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions libvmaf/src/libvmaf.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -649,6 +649,12 @@ static int flush_context_threaded(VmafContext *vmaf)
for (unsigned i = 0; i < rfe.cnt; i++) {
if (!(rfe.fex_ctx[i]->fex->flags & VMAF_FEATURE_EXTRACTOR_TEMPORAL))
continue;
/* CUDA feature extractors are flushed by the HAVE_CUDA block in
* flush_context(); flushing them here as well double-appends their
* final scores. */
if (rfe.fex_ctx[i]->fex->flags & VMAF_FEATURE_EXTRACTOR_CUDA)
continue;

err |= vmaf_feature_extractor_context_flush(rfe.fex_ctx[i],
vmaf->feature_collector);
}
Expand Down