functools.cache on property accessors leaks instances and returns wrong values across same-id objects - #233
Draft
NandaScott wants to merge 1 commit into
Draft
functools.cache on property accessors leaks instances and returns wrong values across same-id objects#233NandaScott wants to merge 1 commit into
NandaScott wants to merge 1 commit into
Conversation
…230) functools.cache keyed on self via __hash__/__eq__, causing two problems: instances were never GC'd (cache held strong refs), and objects sharing a Scryfall ID silently returned each other's cached values. Switching all three accessors (ScryfallListMixin.data, GameplayFieldsMixin.all_parts, GameplayFieldsMixin.card_faces) to cached_property stores the value in the instance __dict__, so it dies with the instance and cannot bleed across objects. Also corrects the __hash__ docstring (said "class name" but the fallback is hash(id(self))). Regression tests added for GC and isolation. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
NandaScott
marked this pull request as draft
August 11, 2026 17:55
Owner
Author
|
Wasn't expecting sandcastle to open this PR. Drafted until I can verify the claims in the original issue. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #230
Opened by Sandcastle. 1 commit(s) on
sandcastle/issue-230.