Prd/property sweep engine - #231
Draft
NandaScott wants to merge 5 commits into
Draft
Conversation
NandaScott
changed the base branch from
develop
to
testing_overhaul_initiative
August 11, 2026 17:35
Scryfall deprecated foil/nonfoil in favor of finishes in 2021 but still returns both on every card object. The sweep's reverse coverage guard flagged them; they had been deleted from the named.json fixture to silence it, which broke the fixture's fidelity to the captured response. Restore the fixture keys and expose the fields via .get() with a deprecation note, matching how symbology exposes the deprecated cmc field. Nullable access degrades to None if Scryfall ever completes the removal.
This was referenced Aug 11, 2026
NandaScott
marked this pull request as draft
August 11, 2026 20:27
Owner
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #180