Start Qdrant the way the runner can, not the way Linux can - #118
Merged
Conversation
The macOS runner has no Docker, so the step that proves the CLI binary died on docker: command not found before it ran anything. This repository already knew that: ci.yml's native-contract-macos job downloads the released Qdrant binary for exactly this reason, and the release workflow was written without reusing it. Starting Qdrant is now its own step and picks by RUNNER_OS: the image on Linux, the released aarch64-apple-darwin binary on macOS. Proving the binary is a second step that assumes only a Qdrant on 6333. The Linux job passed on the run that found this, which is what makes the fix narrow: kdrant migrate created its target, copied both points, verified at recall 1.0, took a snapshot and scrolled it back. The macOS binary is the one most people will download onto a laptop, so proving it only on Linux would have left the one that matters most unrun.
|
This pull request adds no capability the code did not already have. 1 file read · 8 ms · against |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
v2.2.0release got further and stopped again, one step short.What passed
The Linux CLI job succeeded, which is the proof the previous fix needed. The binary did this
against a real Qdrant:
It created the target from the source's own vectors, copied, verified, snapshotted and scrolled.
What failed
The macOS job, on
docker: command not found. A GitHub macOS runner has no Docker, and this repositoryalready knew that:
ci.yml'snative-contract-macosjob downloads the released Qdrant binary forexactly this reason. The release workflow was written without reusing that, which is a harness bug and
not a product one.
Starting Qdrant is now its own step that picks by
RUNNER_OS: the image on Linux, the releasedaarch64-apple-darwinbinary on macOS. Proving the binary is a second step that assumes only thatsomething is answering on 6333.
Proving the binary only on Linux was the other option and is the wrong one. The macOS binary is the one
most people will download onto a laptop, so skipping it would leave the one that matters most as the
only artefact in the release nobody had ever run.
Nothing was published
publishhasneeds: cliand was skipped, twice now. There is no2.2.0on Maven Central and noGitHub Release. The tag moves to this merge commit when it lands.