Skip to content

Fix: add missing toleration to vgpu-device-manager daemonset manifest #2725

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tariq1890 merged 1 commit into from
Aug 10, 2026
+22 −0
Merged

Fix: add missing toleration to vgpu-device-manager daemonset manifest #2725

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions assets/state-vgpu-device-manager/0600_daemonset.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,10 @@ spec:
nodeSelector:
nvidia.com/gpu.deploy.vgpu-device-manager: "true"
priorityClassName: system-node-critical
tolerations:
- key: nvidia.com/gpu
operator: Exists
effect: NoSchedule
serviceAccountName: nvidia-vgpu-device-manager
initContainers:
- name: vgpu-manager-validation
Expand Down
18 changes: 18 additions & 0 deletions controllers/transforms_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -689,6 +689,24 @@ func TestApplyCommonDaemonSetConfig(t *testing.T) {
},
}),
},
{
description: "existing tolerations preserved when daemonsets spec is empty",
ds: NewDaemonset().WithTolerations([]corev1.Toleration{
{
Key: "nvidia.com/gpu",
Operator: corev1.TolerationOpExists,
Effect: corev1.TaintEffectNoSchedule,
},
}),
dsSpec: gpuv1.DaemonsetsSpec{},
expectedDs: NewDaemonset().WithTolerations([]corev1.Toleration{
{
Key: "nvidia.com/gpu",
Operator: corev1.TolerationOpExists,
Effect: corev1.TaintEffectNoSchedule,
},
}),
},
{
description: "invalid updatestrategy configured",
ds: NewDaemonset(),
Expand Down
Loading