Skip to content

fix node permissions for computedomain plugin - #2714

Merged
rahulait merged 1 commit into
NVIDIA:mainfrom
rahulait:fix-computedomain-node-permission
Aug 10, 2026
Merged

fix node permissions for computedomain plugin#2714
rahulait merged 1 commit into
NVIDIA:mainfrom
rahulait:fix-computedomain-node-permission

Conversation

@rahulait

@rahulait rahulait commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

Description

These permissions are coming from: https://github.com/kubernetes-sigs/dra-driver-nvidia-gpu/blob/9c52a7d50994adbf2fbb5f1ce2f6466fa3f9936f/deployments/helm/dra-driver-nvidia-gpu/templates/rbac-kubeletplugin.yaml#L17-L19

Checklist

  • No secrets, sensitive information, or unrelated changes
  • Lint checks passing (make lint)
  • Generated assets in-sync (make validate-generated-assets)
  • Go mod artifacts in-sync (make validate-modules)
  • Test cases are added for new code paths

Testing

Verified using:

kubectl auth can-i patch nodes   --as=system:serviceaccount:gpu-operator:nvidia-dra-driver-kubeletplugin
Warning: resource 'nodes' is not namespace scoped

yes

@rahulait
rahulait force-pushed the fix-computedomain-node-permission branch from 0a42527 to ae6bfc5 Compare August 4, 2026 14:42
@rahulait
rahulait marked this pull request as ready for review August 4, 2026 14:48
@rahulait rahulait self-assigned this Aug 4, 2026
@rahulait rahulait added this to the v26.7 milestone Aug 4, 2026
Comment thread manifests/state-dra-driver/0200_kubeletplugin-clusterrole.yaml
@tariq1890

Copy link
Copy Markdown
Contributor

Don't we need to add the other permissions mentioned in the ClusterRole from the upstream DRA driver helm chart?

@rahulait

rahulait commented Aug 4, 2026

Copy link
Copy Markdown
Contributor Author

Looks like ubuntu/canonical apt servers are having issues, driver installs are taking ages to finish and our e2e tests won't finish on time.

@rahulait

rahulait commented Aug 4, 2026

Copy link
Copy Markdown
Contributor Author

Don't we need to add the other permissions mentioned in the ClusterRole from the upstream DRA driver helm chart?

Other required permissions remain in the existing general clusterrole https://github.com/NVIDIA/gpu-operator/blob/main/manifests/state-dra-driver/0200_kubeletplugin-clusterrole.yaml. Are you looking for any specific RBAC which is missing?

Signed-off-by: Rahul Sharma <rahulsharm@nvidia.com>
@rahulait
rahulait force-pushed the fix-computedomain-node-permission branch from ae6bfc5 to 8257748 Compare August 10, 2026 16:50
@rahulait

Copy link
Copy Markdown
Contributor Author

@rajathagasthya @cdesiniotis re-requesting review as I've updated the PR based on our discussions.

@rahulait
rahulait merged commit 1544577 into NVIDIA:main Aug 10, 2026
36 of 38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants