ci: make pr-test-summary and NVSkills CI checks non-blocking - #1696
Open
ramakrishnap-nv wants to merge 2 commits into
Open
ci: make pr-test-summary and NVSkills CI checks non-blocking#1696ramakrishnap-nv wants to merge 2 commits into
ramakrishnap-nv wants to merge 2 commits into
Conversation
- Remove pr-test-summary from pr-builder needs; it runs independently via if: always() and posts PR comments without gating merge - Remove continue-on-error from pr-test-summary; non-blocking is now expressed by exclusion from pr-builder rather than suppressing failures - Remove continue-on-error from multi-gpu-cpp-tests; now properly blocking through pr-builder as the test suite has matured - Add name "PR test summary (non-blocking)" and "NVSkills CI (non-blocking)" to make advisory status visible in the PR checks UI
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughThe PR updates GitHub Actions job dependencies, failure handling, and display names in the PR and NVSkills CI workflows. ChangesCI workflow updates
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
CI Test Summary⏭️ All 5 test job(s) skipped. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pr-test-summary: removed frompr-builderneeds and droppedcontinue-on-error; non-blocking via exclusion from the merge gate, labeled in the checks UI as non-blockingmulti-gpu-cpp-tests: removedcontinue-on-error; now properly blocking throughpr-builderrequire-nvskills-ci: labeled as non-blocking in the checks UI (already excluded frompr-builder)Testing
CI will validate on this PR.
Docs
No documentation changes.