Skip to content

ci: make pr-test-summary and NVSkills CI checks non-blocking - #1696

Open
ramakrishnap-nv wants to merge 2 commits into
mainfrom
ci/nvskills-non-blocking-ci-checks
Open

ci: make pr-test-summary and NVSkills CI checks non-blocking#1696
ramakrishnap-nv wants to merge 2 commits into
mainfrom
ci/nvskills-non-blocking-ci-checks

Conversation

@ramakrishnap-nv

Copy link
Copy Markdown
Collaborator

Summary

  • pr-test-summary: removed from pr-builder needs and dropped continue-on-error; non-blocking via exclusion from the merge gate, labeled in the checks UI as non-blocking
  • multi-gpu-cpp-tests: removed continue-on-error; now properly blocking through pr-builder
  • require-nvskills-ci: labeled as non-blocking in the checks UI (already excluded from pr-builder)

Testing

CI will validate on this PR.

Docs

No documentation changes.

- Remove pr-test-summary from pr-builder needs; it runs independently
  via if: always() and posts PR comments without gating merge
- Remove continue-on-error from pr-test-summary; non-blocking is now
  expressed by exclusion from pr-builder rather than suppressing failures
- Remove continue-on-error from multi-gpu-cpp-tests; now properly
  blocking through pr-builder as the test suite has matured
- Add name "PR test summary (non-blocking)" and "NVSkills CI (non-blocking)"
  to make advisory status visible in the PR checks UI
@ramakrishnap-nv
ramakrishnap-nv requested a review from a team as a code owner August 10, 2026 16:36
@ramakrishnap-nv
ramakrishnap-nv requested a review from bdice August 10, 2026 16:36
@ramakrishnap-nv ramakrishnap-nv self-assigned this Aug 10, 2026
@ramakrishnap-nv ramakrishnap-nv added non-breaking Introduces a non-breaking change improvement Improves an existing functionality labels Aug 10, 2026
@coderabbitai

coderabbitai Bot commented Aug 10, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 9dc47a26-c0b5-4d90-b5e4-142ed2af1e6e

📥 Commits

Reviewing files that changed from the base of the PR and between 05e606a and 6b60a03.

📒 Files selected for processing (1)
  • .github/workflows/pr.yaml
🚧 Files skipped from review as they are similar to previous changes (1)
  • .github/workflows/pr.yaml

📝 Walkthrough

Walkthrough

The PR updates GitHub Actions job dependencies, failure handling, and display names in the PR and NVSkills CI workflows.

Changes

CI workflow updates

Layer / File(s) Summary
PR workflow execution
.github/workflows/pr.yaml
pr-builder no longer depends on pr-test-summary. The checks job ignores pr-test-summary. The multi-GPU test job no longer allows failures. The PR test summary job is named PR test summary (non-blocking) and retains unconditional execution.
NVSkills job labeling
.github/workflows/request-nvskills-ci.yml
The require-nvskills-ci job is named NVSkills CI (non-blocking).

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related PRs

  • NVIDIA/cuopt#1674: Both PRs modify NVSkills CI workflow behavior, including the require-nvskills-ci job.

Suggested reviewers: bdice

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly summarizes the main CI change: making pr-test-summary and NVSkills CI checks non-blocking.
Description check ✅ Passed The description accurately explains the non-blocking checks, blocking multi-GPU tests, and validation plan.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch ci/nvskills-non-blocking-ci-checks

Comment @coderabbitai help to get the list of available commands.

@github-actions

Copy link
Copy Markdown

CI Test Summary

⏭️ All 5 test job(s) skipped.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

improvement Improves an existing functionality non-breaking Introduces a non-breaking change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant