-
Notifications
You must be signed in to change notification settings - Fork 218
build(cmake): split libcuopt into cuopt_base / cuopt_routing / cuopt_lp component libs #1622
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ramakrishnap-nv
wants to merge
31
commits into
main
Choose a base branch
from
feat/split-routing-lp-libs
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 21 commits
Commits
Show all changes
31 commits
Select commit
Hold shift + click to select a range
9b3d53b
build(cmake): split libcuopt into cuopt_base / cuopt_routing / cuopt_…
ramakrishnap-nv 94755a0
build(cmake): fix component library linking and include propagation
ramakrishnap-nv 0390d40
build(conda): verify component static libs in libcuopt package_contents
ramakrishnap-nv efc5256
build(cmake): switch component libs to SHARED and move gRPC bridge in…
ramakrishnap-nv 08c8db4
build(cmake): extract gRPC bridge into libcuopt_grpc.so
ramakrishnap-nv ec81ebc
Merge origin/main into feat/split-routing-lp-libs
ramakrishnap-nv a54e62a
chore: fix copyright year in routing CMakeLists.txt
ramakrishnap-nv 6c24d1f
fix(ci): exclude component libs from auditwheel repair in cuopt wheel
ramakrishnap-nv 705167f
fix(cmake): include gRPC sources in cuopt_objs for cuopt_static test …
ramakrishnap-nv a42419b
fix(cmake): link cuopt_cli against cuopt_grpc for runtime symbol reso…
ramakrishnap-nv 776bd3b
fix(cli): use is_remote_execution_enabled() not memory_backend==CPU
ramakrishnap-nv 1bc38f7
Merge origin/main into feat/split-routing-lp-libs
ramakrishnap-nv 8511bd0
style: apply clang-format to cuopt_cli.cpp
ramakrishnap-nv f2b22e7
fix(build): link nccl_external into cuopt_lp
ramakrishnap-nv 90ee992
fix(build): break circular libcuopt_lp → libcuopt_grpc symbol dependency
ramakrishnap-nv a83e0f4
fix(build): add libcuopt_grpc.so anchor to umbrella DT_NEEDED
ramakrishnap-nv 0f3b7e1
fix(build): load libcuopt_grpc.so on demand via dlopen for remote exe…
ramakrishnap-nv b872bfb
style: apply clang-format and fix copyright years
ramakrishnap-nv 7b32d1b
fix(build): allow shlib undefined for split libs, ignore pypi in link…
ramakrishnap-nv 80c1c34
fix(build): add cuopt_lp/cuopt_base to pip RPATH in libcuopt CMakeLists
ramakrishnap-nv 91f5b84
fix(build): address review — DT_NEEDED anchors, export names, registr…
ramakrishnap-nv fe01c17
fix(build): gate remote-solver registry on an explicit ready flag
ramakrishnap-nv a5000c3
Merge branch 'main' into feat/split-routing-lp-libs
ramakrishnap-nv 1c4cdbd
build(cmake): rename cuopt_lp to cuopt_mathematical_optimization
ramakrishnap-nv b3b8702
build(cmake): ship libcuopt.so as a linker script
ramakrishnap-nv 6647ae4
style: apply clang-format and refresh copyright year
ramakrishnap-nv 2c6e20c
Merge branch 'main' into feat/split-routing-lp-libs
ramakrishnap-nv a009e20
Merge branch 'main' into feat/split-routing-lp-libs
ramakrishnap-nv 34070b1
chore: drop stray files committed by mistake
ramakrishnap-nv 38b15e1
fix(build): drop argparse from the cuopt INTERFACE target
ramakrishnap-nv c7b70da
fix(build): ship libcuopt.so linker script in the wheel
ramakrishnap-nv File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We might want to call this
libcuopt_mathematical_optimization.so. We are trying to move away fromlpThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isn't it a very long name for a library? Normally libraries have very short names and many libraries use abbreviations. Maybe we could do something like:
libcuopt_mathopt.so?