ci(workflows): remove obsolete base compatibility paths - #8636
Merged
Conversation
Contributor
📝 WalkthroughWalkthroughChangesThe CI workflows now invoke trusted base-commit actions directly. They remove tool detection, bootstrap checkout and validation, fallback execution, and related contract paths. Shell scanning and growth guardrail checks run unconditionally. Trusted CI workflows
Estimated code review effort: 4 (Complex) | ~45 minutes Sequence Diagram(s)sequenceDiagram
participant PullRequest
participant PRCheckout
participant BaseTrustedCheckout
PullRequest->>PRCheckout: provide workflow and installer data
PullRequest->>BaseTrustedCheckout: invoke trusted base-commit actions
BaseTrustedCheckout->>PRCheckout: run checks and return results
Possibly related PRs
Suggested labels: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
Contributor
Contributor
PR Review Advisor — No blocking findings reportedAdvisor assessment: No blocking advisor findings reported Model lanes
2 additional E2E selections from the second opinionAdvisory only. The primary lane did not select these E2E jobs or targets.
Second-opinion terminology and E2E selections are advisory. Live E2E does not run automatically for pull requests. 2 semantic terminology decisionsTerminology decisions are advisory. They affect the assessment only when a separate finding identifies concrete semantic impact.
E2E guidanceAdvisory only. A maintainer can dispatch the default E2E suite against this exact revision. Recommended E2E: This automated review informs maintainers. Warnings and suggestions do not require a response. A maintainer decides whether to merge. |
Contributor
|
🌿 Preview your docs: https://nvidia-preview-pr-8636.docs.buildwithfern.com/nemoclaw |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@test/pr-workflow-contract.test.ts`:
- Around line 313-320: Update the allowed-executor validation around
allowedExecutors and installerHashTrustViolations so the local
ci-installer-hash-check action is permitted only when its step condition
excludes pull requests; reject PR-only conditions such as github.event_name ==
'pull_request'. Add a fixture containing a PR-only local executor and assert
that installerHashTrustViolations reports it.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: 18320702-800b-4a63-aa86-4cce868cd345
📒 Files selected for processing (6)
agents/openclaw/dependency-review.mdci/source-shape-test-budget.jsondocs/security/openclaw-2026.6.10-dependency-review.mdscripts/check-installer-hash.shtest/pr-workflow-contract.test.tstest/reviewed-npm-audit-workflow.test.ts
💤 Files with no reviewable changes (1)
- test/reviewed-npm-audit-workflow.test.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Pull request CI previously carried compatibility branches for base revisions that lacked current trusted helpers. The workflows now execute the helpers from the PR base SHA and fail when that trusted interface is absent.
Changes
.github/workflows/pr.yaml.Type of Change
Quality Gates
Documentation Writer Review
docs-updatedDGX Station Hardware Evidence
Verification
Signed-off-by:line and every commit appears asVerifiedin GitHubpre-commit,commit-msg, andpre-pushhooks passed, ornpm run validate:prpassed after refreshingorigin/mainwhen hooks were skipped or unavailablenpm testfor broad runtime/test-harness changes;npm run checkfor repo-wide validation/coverage changes — command/result:npm run docsbuilds without warnings (doc changes only)Signed-off-by: Carlos Villela cvillela@nvidia.com
Summary by CodeRabbit
Workflow Improvements
Tests
Documentation